Upgrade taffy for last-baseline support - #721
Open
nicoburns wants to merge 2 commits into
Open
Conversation
Contributor
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
staging-devin-ai-integration
Bot
force-pushed
the
devin/1786754807-taffy-last-baseline
branch
from
August 18, 2026 19:06
6b1969a to
a52a3ac
Compare
staging-devin-ai-integration
Bot
force-pushed
the
devin/1786754807-taffy-last-baseline
branch
from
August 19, 2026 00:18
a52a3ac to
44afae3
Compare
staging-devin-ai-integration
Bot
force-pushed
the
devin/1786754807-taffy-last-baseline
branch
from
August 19, 2026 12:03
e524553 to
3c07d0e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bumps taffy to the tip of taffy#1113 (
bb30dbf2, top of the stacked series #1110 → #1111 → #1113, which includes latest taffy main) and adapts Blitz to the new last-baseline APIs:LayoutOutput::baselines: Baselines { first, last }(previously only the first, viaBaselines::from_first).stylo::AlignFlags::LAST_BASELINEnow maps to the realtaffy::AlignItems::LAST_BASELINEinstead of falling back toEND.Rebased on main, which already includes the
Baselinestype andscrollable_overflow_rectmigrations (#733), so the diff is now just the rev bump plus the two behavioral changes above.Should merge only after the taffy stack lands; the
revshould ideally then be bumped to the merge commit.Link to Devin session: https://dioxus.staging.devinenterprise.com/sessions/c0a80d9344d54e918b37cacfb71a2128
Requested by: @nicoburns