Skip to content

Upgrade taffy for last-baseline support - #721

Open
nicoburns wants to merge 2 commits into
mainfrom
devin/1786754807-taffy-last-baseline
Open

Upgrade taffy for last-baseline support#721
nicoburns wants to merge 2 commits into
mainfrom
devin/1786754807-taffy-last-baseline

Conversation

@nicoburns

@nicoburns nicoburns commented Aug 15, 2026

Copy link
Copy Markdown
Member

Summary

Bumps taffy to the tip of taffy#1113 (bb30dbf2, top of the stacked series #1110 → #1111 → #1113, which includes latest taffy main) and adapts Blitz to the new last-baseline APIs:

  • Inline layout now reports both first and last Parley line baselines via LayoutOutput::baselines: Baselines { first, last } (previously only the first, via Baselines::from_first).
  • stylo::AlignFlags::LAST_BASELINE now maps to the real taffy::AlignItems::LAST_BASELINE instead of falling back to END.

Rebased on main, which already includes the Baselines type and scrollable_overflow_rect migrations (#733), so the diff is now just the rev bump plus the two behavioral changes above.

Should merge only after the taffy stack lands; the rev should ideally then be bumped to the merge commit.

Link to Devin session: https://dioxus.staging.devinenterprise.com/sessions/c0a80d9344d54e918b37cacfb71a2128
Requested by: @nicoburns

@staging-devin-ai-integration

Copy link
Copy Markdown
Contributor

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

  • Address comments on this PR that start with 'DevinAI' or '@devin'.
  • Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

  • Disable automatic comment, CI, and merge conflict monitoring
@staging-devin-ai-integration
staging-devin-ai-integration Bot force-pushed the devin/1786754807-taffy-last-baseline branch from e524553 to 3c07d0e Compare August 19, 2026 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

1 participant