Support justify-self on block-level boxes - #673
Open
nicoburns wants to merge 1 commit into
Open
Conversation
Contributor
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Block-level boxes now honour
justify-self(/css/css-align/self-alignment/block-justify-self.html). Taffy gained the block-layout implementation in DioxusLabs/taffy#1086; this side just feeds Stylo's computed value into the new style accessor:taffyis patched to that PR's branch until it is released, matching the existingusvg/anyrenderpatches.Verified against Chrome: every alignment row of the WPT fixture (all keywords, LTR/RTL containers,
direction-differing children, auto/explicit widths, margins, floats, absolute children) now lands at the same x as Chrome, and matches the grid reference in Blitz's own rendering. The reftest still fails on vertical offsets only: Blitz's text metrics wrapself-start (rtl)onto two lines where Chrome fits one, so the rows below the float row are shifted 19px in the test but not in the reference — a font/inline-layout difference unrelated to alignment.Link to Devin session: https://dioxus.staging.devinenterprise.com/sessions/49e63862a7874317af1f714bb5da599a
Requested by: @nicoburns
WPT results
13 newly passing, 1 newly failing (net +12).
Full diff (14 changed tests)
Generated by the WPT workflow.