Skip to content

Send Gateway reconnect email#2398

Merged
moubctez merged 1 commit into
devfrom
gateway_reconnect_email
Mar 18, 2026
Merged

Send Gateway reconnect email#2398
moubctez merged 1 commit into
devfrom
gateway_reconnect_email

Conversation

@moubctez

@moubctez moubctez commented Mar 18, 2026

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR extends gateway email notification behavior by adding a “gateway reconnected” notification (with an inactivity threshold), and adjusts build-time version metadata generation in defguard_common.

Changes:

  • Add reconnect email notification flow in GatewayHandler and trigger it on successful gateway connection timestamp update.
  • Update mail handler API for reconnect notifications to require a non-optional gateway name.
  • Simplify defguard_common build metadata generation by removing branch emission and adjusting vergen-git2 dependency usage.

Reviewed changes

Copilot reviewed 4 out of 5 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
crates/defguard_gateway_manager/src/handler.rs Adds reconnect notification logic and refines disconnect notification gating; triggers reconnect email after touch_connected.
crates/defguard_core/src/handlers/mail.rs Changes send_gateway_reconnected_email to take gateway_name: String (non-optional).
crates/defguard_common/Cargo.toml Simplifies vergen-git2 build-dependency declaration.
crates/defguard_common/build.rs Stops emitting git branch metadata; emits SHA only.
Cargo.lock Updates lockfile to reflect dependency graph changes.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

Comment thread crates/defguard_gateway_manager/src/handler.rs
@moubctez moubctez merged commit 764c51d into dev Mar 18, 2026
7 checks passed
@moubctez moubctez deleted the gateway_reconnect_email branch March 18, 2026 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants