This repository was archived by the owner on Feb 25, 2026. It is now read-only.
Fixed the debounce extension in order to update to the last action pa…#4294
Merged
5 commits merged intoOct 7, 2021
Merged
Conversation
|
Thanks matheus-inacio for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌 |
12 tasks
|
|
XAML-Knight
approved these changes
Oct 5, 2021
michael-hawker
approved these changes
Oct 7, 2021
|
Hello @michael-hawker! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4293
PR Type
What kind of change does this PR introduce?
Bugfix
What is the current behavior?
The debounce extension was incorrectly updating the action in the ConcurrentList.
According to documentation the value passed in the
updateValueFactoryfunction, of theAddOrUpdatemethod, is the current value in the dictionary.https://docs.microsoft.com/en-us/dotnet/api/system.collections.concurrent.concurrentdictionary-2.addorupdate?view=net-5.0
Therefore the current behavior is maintaining the old action and not updating with the new passed action.
What is the new behavior?
Changed so that the action in the
_ debounceInstancesDictionary is updated with the latest version.PR Checklist
Please check if your PR fulfills the following requirements:
Other information
PS: The debuonce extension is referenced in the
CanvasPathGeometryPageclass (although this changes does not seem to break it).