This repository was archived by the owner on Feb 25, 2026. It is now read-only.
Fix MVVM Toolkit build errors when using C# < 9.0#4285
Merged
michael-hawker merged 2 commits intoOct 7, 2021
Merged
Conversation
|
Thanks Sergio0694 for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌 |
Member
Author
|
@michael-hawker We absolutely need to get this one merged in for 7.1.1, as the MVVM Toolkit will just be causing build errors for all customers using C# 7.3 or lower otherwise if they use either |
XAML-Knight
approved these changes
Sep 30, 2021
michael-hawker
approved these changes
Oct 7, 2021
michael-hawker
left a comment
Member
There was a problem hiding this comment.
Tested with an ObservableValidator on a file new project before and after and seemed to work great, thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4269 (comment)
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Using
ObservableValidatororIRecipient<T>from the MVVM Toolkit causes a build error when using C# < 9.0.What is the new behavior?
Fixed those build warnings. We should only restrict to C# 9 for the explicitly used source generator features.
These two instead don't need any new C# syntax, so they should work just fine even on C# 8.0.
If an even lower version of C# is set, then the two generators will just not run.
PR Checklist
Please check if your PR fulfills the following requirements: