You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The GazeInteraction library implementation of OneEuroFilter is broken. The conversion from C++ to C# broke a calculation between time and frequency. The 100000000.0f (1e8) in the following line should be 10000000.0f (1e7).
var samplingFrequency = (float)TimeSpan.TicksPerSecond / Math.Max(1, (args.Timestamp - _lastTimestamp).Ticks);
Is this bug a regression in the toolkit? If so, what toolkit version did you last see it work:
The calculation was correct in the C++ implementation (probably).
Steps to Reproduce
Error was found during a code inspection; the actual code is not used in the current implementation of GazeInteraction, though it is theoretically available for consuming code to use.
Can this be reproduced in the Sample App? (Either in a sample as-is or with new XAML pasted in the editor.) If so, please provide custom XAML or steps to reproduce. If not, let us know why it can't be reproduced (e.g. more complex setup, environment, dependencies, etc...)
Steps to reproduce the behavior:
Given the following environment (Sample App w/ XAML, Project with Isolated setup, etc...)
Describe the bug
The GazeInteraction library implementation of OneEuroFilter is broken. The conversion from C++ to C# broke a calculation between time and frequency. The 100000000.0f (1e8) in the following line should be 10000000.0f (1e7).
This:
float samplingFrequency = 100000000.0f / Math.Max(1, (args.Timestamp - _lastTimestamp).Ticks);
Is better expressed as:
var samplingFrequency = (float)TimeSpan.TicksPerSecond / Math.Max(1, (args.Timestamp - _lastTimestamp).Ticks);
The calculation was correct in the C++ implementation (probably).
Steps to Reproduce
Error was found during a code inspection; the actual code is not used in the current implementation of GazeInteraction, though it is theoretically available for consuming code to use.
Steps to reproduce the behavior:
Expected behavior
Screenshots
Environment
NuGet Package(s):
Package Version(s):
Windows 10 Build Number:
App min and target version:
Device form factor:
Visual Studio version:
Additional context