Update AWS and Rubocop gems#34
Merged
Merged
Conversation
bharanin
commented
Mar 15, 2018
bharanin
commented
Member
- Updating AWS SDK to v3 so we can start using new services like Fargate
- Updating RuboCop since it has a CVE
- Code/Syntax updated to make new version of RuboCop happy
sr523
reviewed
Mar 15, 2018
| end | ||
|
|
||
| # Set the name of the instance that will be displayed in the ec2 console | ||
| def rename_instance(instance, name) |
Contributor
There was a problem hiding this comment.
Should we just remove these empty methods?
Member
Author
There was a problem hiding this comment.
makes sense - doing that now
sbower
approved these changes
Mar 15, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.