Skip to content

Add a rule to detect LTR properties#533

Open
lewisnyman wants to merge 6 commits into
CSSLint:masterfrom
lewisnyman:ltr-detection
Open

Add a rule to detect LTR properties#533
lewisnyman wants to merge 6 commits into
CSSLint:masterfrom
lewisnyman:ltr-detection

Conversation

@lewisnyman
Copy link
Copy Markdown

Drupal has a requirement to support RTL languages, this is a lot of work to achieve and often slips through our review process. I want to make csslint a formal part of our review process and having a rule that detects LTR specific properties would be a great help.

I've opened the equivalent issue to track this on Drupal.org here:
https://www.drupal.org/node/2313783

@stubbornella
Copy link
Copy Markdown
Member

Do you hand roll LTR files or generate them with something like CSSJanus?

http://cssjanus.commoner.com

On Fri, Aug 1, 2014 at 5:55 AM, Lewis Nyman notifications@github.com
wrote:

Drupal has a requirement to support RTL languages, this is a lot of work to achieve and often slips through our review process. I want to make csslint a formal part of our review process and having a rule that detects LTR specific properties would be a great help.
I've opened the equivalent issue to track this on Drupal.org here:

https://www.drupal.org/node/2313783

Reply to this email directly or view it on GitHub:
#533

@lewisnyman
Copy link
Copy Markdown
Author

We used to hand roll separate files, which was a maintenance nightmare. Now we've switched to using [dir="rtl"] selectors directly after the LTR CSS in Drupal 8.

I've never seen CSSJanus before, interesting! I'll ask around if it's been tried previously.

@lewisnyman
Copy link
Copy Markdown
Author

I had a lot of fun working on this rule, the test process is great!

I don't know if this rule should be added to csslint or if it's applicable to everyone, but it would be nice to get some feedback.

@hartman
Copy link
Copy Markdown
Contributor

hartman commented Dec 5, 2014

@lewisnyman BTW, there is also a php version of cssjanus. We use it in MediaWiki and it really saves you a ton of trouble.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the trailing comma.

@frvge frvge added the Rule label Jan 10, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

4 participants