@tahirmehmoodkhokhar forums have a long history of being paired with gaming. Many of the top AAA gaming companies have (or had) forums.

Discord has supplanted them but it provides a far inferior experience compared to a forum.

@[email protected] probably not, that instance is hosted on a potato server on purpose so I am incentivise to keep the code lean.

It happens occasionally

if (notification.mergeId) {
    const related = await Notifications.findRelated([notification.mergeId], `uid:${uid}:notifications:unread`);
    const merged = await Notifications.getMultiple(related).then(Notifications.merge);
    if (merged.length) {
        notification = merged.pop();
        notification.pushed = false; // Ensure it re-triggers the push for the update
    }
}

This code is in the web-push plugin, not core. Is there another change that you made that you didn't post in your reply?

@שניאור-שמח is that a pull request open to the plugin? I don't see it.

@שניאור-שמח my best guess is that the notification is received by web push and it does not correctly "rescind" the push notification when issuing a new one with an identical merge id

However if it works with Android then that suggests that it may be an apple specific issue with how they handle notification rescind. Maybe they require additional data the plugin doesn't send.

Hopefully they support notification rescind.

I think all the functionality is in nodebb-plugin-web-push. The notification is shown here https://github.com/NodeBB/nodebb-plugin-web-push/blob/main/static/web-push.js#L16. You can check there if every chat message push comes with a different body or if they are identical.

Try with 6.0.9, I think the assets were built at startup on all processes.

Yeah without an iphone it's not possible to test it, the change the in the PR looked good to me so if that don't work, I am out of ideas.

@downpw actually it was right at the top

Can you try with [email protected], you can remove the isPrimary: true from config.json.

Let me know if it works.

@downpw yeah you shouldn't add isPrimary: true to config.json, as you noticed that makes all the 3 nodebb processes primary which is not what you want.

I will take a look at the emoji plugin, I think we can refactor pubsub.js so it builds even if you are not on the primary and using pubsub to build on different hosts.

Nevermind I see it is 20.x on your screenshots, once you upgrade it to 22 or 24, it will work fine.

@cagatay what is your nodejs version? Make sure it is 22.x or 24.x.

You will need to add some logs in the pubsub file in emoji plugin. https://github.com/NodeBB/nodebb-plugin-emoji/blob/master/lib/pubsub.ts find the built js file for this in node_modules.

Are you running more than 1 nodebb process? Do you have redis setup or so you use singleHostCluster in config.json?

@cagatay open the log file and post the rest of the error.

@שניאור-שמח unfortunately I don't have an iphone so I can't test the changes.

The code in that pull request isn't merged yet, so it is not active in the latest version of nodebb. Once it's merged and published you can install and test it. Or you can replace the plugin with your own version for testing.

@julian seems like safari is picky about replacing same notifs with tag, the PR on the repo has some code to handle safari via mergeId.

@שניאור-שמח are chats the only type of notification failing at merging?

@baris web push is a direct reflection of regular notifications so if they share merge id, the old push notif is removed and replaced

These are push notifications so they are likely handled in the web-push plugin, I see a PR there https://github.com/NodeBB/nodebb-plugin-web-push/pull/64 that might fix this issue @julian