Getting SharePoint users and comparing them with SPList

Question

I have a custom SPList that has a field Assigned To, now I can add as many items as I want, and they can have same title and same User they are assigned to, but what I want is a script so that I only get the distinct number of user's email address, e.g. if a user is assigned to more then 1 item, I will get there email address just once, here is the code I wrote down but I don't think if its good enough.

using (SPSite site = new SPSite("www.local.com"))
    using (SPWeb web = site.OpenWeb())
    {
        SPList mySourceList = web.Lists["ListName"];

        SPQuery mySourceListQuery = new SPQuery();

        mySourceListQuery.Query =

            "<OrderBy><FieldRef Name='AssignedTo' />" +
                     "<FieldRef Name='Title' />" +
            "</OrderBy>";



        SPListItemCollection mySourceItemColl = mySourceList.GetItems(mySourceListQuery);


        foreach (SPUser user in web.Users)
        {
            foreach (SPListItem mySourceListItem in mySourceItemColl)
            {
                name = mySourceListItem["AssignedTo"].ToString();

                name = name.Substring(name.IndexOf("#") + 1);

                if (user.Name == name)
                {
                    Console.WriteLine(user.Email);
                }
            }
        }

Rich Bennema · Accepted Answer · 2012-06-20 20:11:11Z

As written, your code will process each item in mySourceItemColl for every user in the site. I would prefer to only go through the collection one time.

As such, I would write it more like this:

using (SPSite site = new SPSite("www.local.com"))
    using (SPWeb web = site.OpenWeb())
    {
        SPList list = web.Lists["ListName"];
        SPQuery query = new SPQuery();
        query.Query =
            "<OrderBy><FieldRef Name='AssignedTo' />" +
                "<FieldRef Name='Title' />" +
            "</OrderBy>";
        SPitemCollection items = list.Getquery(query);
        List<string> emails = new List<string>();
        foreach (SPListItem item in items)
        {
            SPFieldUserValue value = 
                new SPFieldUserValue(web, item["AssignedTo"].ToString());
            if (null != value && 
                null != value.User && 
                !emails.Contains(value.User.Email)) 
            {
                emails.Add(value.User.Email);
                Console.WriteLine(value.User.Email);
            }
        }
    }
}

palacsint · Accepted Answer · 2012-06-20 17:26:54Z

2

The my prefixes are unnecessary, I'd call the variables sourceList, sourceListQuery, sourceItems etc.
I'd create a method for this:
```
name = name.Substring(name.IndexOf("#") + 1);
```
I guess removeId could be a good name. The method name would help readers to understand the intent of the writer.

answered Jun 20, 2012 at 17:26

palacsint

30.4k9 gold badges82 silver badges157 bronze badges

Add a comment |

Stack Exchange Network

Getting SharePoint users and comparing them with SPList

2 Answers 2

You must log in to answer this question.

Hot Network Questions

Getting SharePoint users and comparing them with SPList

2 Answers 2

You must log in to answer this question.

Related

Hot Network Questions