Change the switch code

Question

there is a other way to write in JS the switch statement , This code is working :)

_update: function(oHtml, oConfig) {
        var _this = this;
        var oParent;
        if (oConfig.attributes != null) {
            oConfig.attributes.forEach(function(oAttr) {
                //debugger;
                oParent = oHtml.find("#" + oAttr.id);
                switch (oAttr.action) {
                    case 'upd':
                        _this._updateAttr(oParent, oAttr);
                        break;
                    case 'new':
                        _this._insertAttr(oParent, oAttr);
                        break;
                    case 'del':
                        _this._removeAttr(oParent, oAttr);
                }
            });
            return oHtml;
        }
    },

We are using require JS

I can think of multiple ways to write that, yes. Your point? — Mast
– Mast ♦, Commented Apr 18, 2016 at 12:08
Please tell us what this code is for, and title the question accordingly. See How to Ask. — 200_success
– 200_success, Commented Apr 18, 2016 at 16:03

Rodrigo Juarez · Accepted Answer · 2016-04-18 16:58:10Z

3

You can try something like this, saving the names of the functions in a variable, and then accessing the variable with the name of the action, you can also save the reference of the functions of the variable in the properties and you would not have to use 'this'

_update: function(oHtml, oConfig) {
    var _this = this;
    var oParent;
    var actionsToExecute = {
      upd : '_updateAttr',
      new : '_insertAttr',
      del : '_removeAttr'
    }
    if (oConfig.attributes != null) {
        oConfig.attributes.forEach(function(oAttr) {
            //debugger;
            oParent = oHtml.find("#" + oAttr.id);
            _this[actionsToExecute[oAttr.action]](oParent,oAttr)
        });
        return oHtml;
    }
},

answered Apr 18, 2016 at 16:58

Rodrigo Juarez

2561 silver badge4 bronze badges

\$\begingroup\$ Would be even better if you could change the value of oAttr.action to return one of the 3 function name because you wouldn't need the 'actionsToExecute' object. \$\endgroup\$

Kim Aragon Escobar
– Kim Aragon Escobar

2016-04-18 17:19:57 +00:00
Commented Apr 18, 2016 at 17:19
1

\$\begingroup\$ Yes, you're right, I made a clarification in the end. \$\endgroup\$

Rodrigo Juarez
– Rodrigo Juarez

2016-04-18 17:32:19 +00:00
Commented Apr 18, 2016 at 17:32

Add a comment |

Stack Exchange Network

Change the switch code

1 Answer 1

You must log in to answer this question.

Hot Network Questions

Change the switch code

1 Answer 1

You must log in to answer this question.

Related

Hot Network Questions