VBScript undefined variable error

Question

<script language="VBScript">
Option Explicit
' On Error Resume Next


Dim colIPResults, objFile, objFSO, objNIC, objWMI, objWSHNetwork, strAddresses, strIPAddress, strWQL
Const FOR_APPENDING = 8

Sub DestroyObjects()
If IsObject(objFile) Then Set objFile = Nothing
If IsObject(objFSO) Then Set objFSO = Nothing
If IsObject(objWMI) Then Set objWMI = Nothing
If IsObject(objWSHNetwork) Then Set objWSHNetwork = Nothing
' If IsObject() Then Set = Nothing
End Sub


Set objFSO = CreateObject("Scripting.FileSystemObject")
Set objWSHNetwork = CreateObject("WScript.Network")
Set objWMI = GetObject("WinMGMTS:root\cimv2")
Set StrComputer = objWSHNetwork.Computername 
strWQL = "SELECT IPAddress FROM Win32_NetworkAdapterConfiguration WHERE IPEnabled = 'True'"
Set colIPResults = objWMI.ExecQuery(strWQL)
For Each objNIC In colIPResults
For Each strIPAddress in objNIC.IPAddress
If strAddresses = "" Then
strAddresses = strIPAddress
Else
strAddresses = strAddresses
End If
Next
Next

Document.write("PC Tag Number: " + StrComputer)

If strAddresses ="0.0.0.0" Or strAddresses ="" or strAddresses = "undefined" Then
    Document.write("No Connection Detected")
Else
    Document.write "Network Address - "+ strAddresses
End If

DestroyObjects()
</script>

It keeps telling me that the variable is undefined!

(variable for StrComputer)

Carth · Accepted Answer · 2011-11-03 20:14:01Z

3

You never declared StrComputer on line 6.

To elaborate a bit here, you used the Option Explicit which means that you must declare all of your variables before you use them even though we're in VBScript. Because of this you must include StrComputer in your Dim statement on line 6.

Dim colIPResults, objFile, objFSO, objNIC, objWMI, objWSHNetwork, strAddresses, strIPAddress, strWQL, StrComputer.

Also, you appear to have changed the naming convention to use an upper case first letter rather than a lower case (StrComputer vs. strComputer). Although you can certainly name it however you want, you may want to stay consistent so you don't end up with buggy code that still looks right when you read through it.

edited Nov 3, 2011 at 20:14

answered Nov 3, 2011 at 20:06

Carth

2,3431 gold badge17 silver badges27 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

Cocoa Dev Over a year ago

Declare? Please explain. I thought I did by stating Set

Carth Over a year ago

I updated the response to explain why you're seeing this error in VBScript.

Collectives™ on Stack Overflow

VBScript undefined variable error

1 Answer 1

2 Comments

Linked

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

2 Comments

Linked

Related