If Statement for VBScript is not Working. No Errors when executing script [closed]

Question

Closed. This question needs debugging details. It is not currently accepting answers.

Edit the question to include desired behavior, a specific problem or error, and the shortest code necessary to reproduce the problem. This will help others answer the question.

Closed 7 months ago.

Improve this question

I am trying to create a script that reads the contents of a file and reacts to certain error messages. So far everything is working as intended; however, I cannot get the 'If' statement to perform any action. It is intended to read the file and if a error message occurs within the text document, it will just completely taskill the Script. Here is a sample of what I have so far:

Dim WshShell, objfso, LogData, oShell 
  
Const ForReading = 1    
Set objfso = CreateObject("Scripting.FileSystemObject")    
Set objPL = objfso.OpenTextFile("C:\-----", ForReading)    
Set oShell = WScript.CreateObject("WScript.Shell")  
  
error = "Invalid"   
LogData = objPL.ReadAll    

Sub CheckTextFile    
   Do Until objPL.AtEndOfStream    
      If InStr(1, LogData, error) > 0 Then   
        objPL.Close   
        oShell.AppActivate "taskkill /F /IM WScript.exe"    
        WScript.Sleep 2000    
      End If    
   Loop   
End Sub

----- Also you can assume that in my code I already have a text document created with output stating that there is errors that say "Invalid". It seems that anything within my If statement is ignored and skipped. No actions are ever performed from the If statements.

It would be helpful to know what type of object LogData is after the ReadAll because you have not declared/explicitly typed it. It may not be what you assume it is. It would also be helpful to know if you have debugged the results of the ReadAll to confirm that the contents are what you think they are. — AJD
– AJD, Commented Mar 28 at 21:56
@KenWhite: That looks like an (the) answer to me, not a comment. — AJD
– AJD, Commented Mar 29 at 3:26
@AJD The logData line you see is the first mention of it in my code. I am not too proficient in this language, so I thought that I was assigning Line 5 to the constant “LogData”. — Terrence Busby Terrence209
– Terrence Busby Terrence209, Commented Mar 29 at 6:08
@TerrenceBusbyTerrance209 You are assigning it, but the interpreter will assume a type because you have not declared it as a particular type. This means that when you use it later, you are also assuming that it looks like what you thought it would look like. When you use it, you are assuming it is a string. When coding, try to remove as many assumptions as possible. Try RubberduckVBA for some hints about implicit behaviour in VB. — AJD
– AJD, Commented Mar 29 at 22:09
@user692942. Understood. Perhaps a simpler way I could have put it is: Hey, there are a few assumptions because you have not declared types (VBScript is non-typed anyway), and we have not seen any debugging that tests those assumptions. — AJD
– AJD, Commented Apr 1 at 4:21

Geert Bellekens · Accepted Answer · 2025-03-31 06:15:24Z

2

LogData = objPL.ReadAll - You're at the end of the stream after this line. That means that the Do Until objPL.AtEndOfStream block is never entered. Why are you reading the entire stream and then looping that same stream? There's no need for that, because you have the entire contents of the stream in LogData before you start looping. Either just check for the content in LogData once, or read the stream line-by-line instead of reading it all.

You should be able to change your loop to something like this (untested!!):

error = "Invalid"   
StopIt = False

Sub CheckTextFile    
   Do Until StopIt = True
      LogData = objPL.ReadAll    
      If InStr(1, LogData, error) > 0 Then   
        StopIt = True
        objPL.Close   
        oShell.AppActivate "taskkill /F /IM WScript.exe"    
        WScript.Sleep 2000    
      End If    
   Loop   
End Sub

edited Mar 31 at 6:15

Geert Bellekens

13.9k3 gold badges31 silver badges57 bronze badges

answered Mar 29 at 3:30

Ken White

126k15 gold badges237 silver badges476 bronze badges

Sign up to request clarification or add additional context in comments.

6 Comments

Terrence Busby Terrence209 Mar 29 at 18:13

My Log file actively logs data while the script is being run to check for possible error messages. That is why I have it looping. Do you think looping is maybe not the right approach? @KenWhite

Ken White Mar 29 at 21:50

Looping is fine. You just can't do it based on AtEndOfStream. My suggestion would be to move the LogData = objPL.ReadAll' inside the Do Until` loop above the If, set a new variable right above the If such as StopIt = False, change your loop to Do Until StopIt = True, and if you find the error string set StopIt = True to break out of the loop. See my edit to my answer.

user692942 Mar 30 at 8:14

@KenWhite you never set StopIt = True so the loop will never break. Also using taskkill to stop wscript.exe will not guarantee the script ends it would be better to just set StopIt = True which will exit the loop and end the script.

Ken White Mar 30 at 13:49

@user692942: You're right about the first. Corrected my oversight. As to the use of taskkill, I have no idea what the user is trying to do or what else is in the script - StopIt = True just guarantees that the Sub CheckTextFile gets exited.

user692942 Mar 30 at 17:24

So what you’re saying is, the question was unclear and probably shouldn’t have been answered in the first place? I agree.

|

Collectives™ on Stack Overflow

If Statement for VBScript is not Working. No Errors when executing script [closed]

1 Answer 1

6 Comments

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

6 Comments

Related