Deleting char pointer array

Question

I want to delete a char * array, which should be simple right? char * = new char[length]; then use delete[] char;?

Also, I am unable to use std::string for this exercise.

I'm getting this error:

HEAP CORRUPTION DETECTED: after Normal block (#137) 0x00794B50.
CRT detected that the application wrote to memory after end of heap buffer.

Here is my code:

class myClass
{
    char * myString;
    ...
public:
    myClass::myClass( const char * tempStr);
};

myClass::myClass( const char * tempStr)
{
    int length = strlen(tempStr);
    myString = new char(length + 1); //+1 for null char
    strcpy(myString, tempStr);
    myString[length] = '\0';
    delete[] myString; //error occurs here
}

Now, I know, this code is completely impractical, however it still throws the same error that I am trying to solve so if we can solve this then I should be merrily on my way. From what I've read this should be OK? I'll reiterate, for this exercise I cannot use std::string.

Mysticial · Accepted Answer · 2011-10-09 00:58:07Z

7

You messed the brackets up. It should be:

myString = new char[length + 1];

Square brackets will create an array. Normal brackets will allocate only one with whatever constructor takes that one operand.

answered Oct 9, 2011 at 0:58

Mysticial

473k46 gold badges343 silver badges337 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Jace Over a year ago

oh i hate myself. Thank you very much, that worked, will mark as answer asap.

Collectives™ on Stack Overflow

Deleting char pointer array

1 Answer 1

1 Comment

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

1 Comment

Related