loop in javascript

Question

function DC() {
    var elements = $(".panel");
    elements.first().fadeOut(1000, function() {
        $(this).insertAfter(elements.last());
        $(this).fadeIn(1000);
    });
}

$(document).ready(function() {
    var i =0;
    for (var i=0; i < 10; i++) {
        DC();
    };
});

I want DC() to loop 10 times, but it only looped once.

What did I do wrong?

why do you create your var i 2 times? the for(var i = 0; i < 10; i++) should be enough to create your var i. To try find out if your loop really looped once, add an alert or so to check :) — Snicksie
– Snicksie, Commented Sep 28, 2011 at 9:24
Fixed your formatting for you. Please take a moment of care next time. — Lightness Races in Orbit
– Lightness Races in Orbit, Commented Sep 28, 2011 at 9:35

mpartel · Accepted Answer · 2011-09-28 09:21:57Z

5

DC starts a fadeOut 10 times in a row. If you want your elements to fade out and back in 10 times then you should call DC as fadeIn's callback.

elements.first().fadeOut(1000, function() {
    $(this).insertAfter(elements.last());
    $(this).fadeIn(1000, DC);
});

answered Sep 28, 2011 at 9:21

mpartel

4,5021 gold badge27 silver badges31 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Timothy Jones · Accepted Answer · 2011-09-28 09:35:18Z

3

mpartel is correct in that you may want to call DC as a callback - but in order to ensure it doesn't run forever, you'll need to check against a count:

var count = 0;

function DC() {

    elements.first().fadeOut(1000, function() {
        if(count >= 10) return;
        count++;
        $(this).insertAfter(elements.last());
        $(this).fadeIn(1000, DC);
    });
}

answered Sep 28, 2011 at 9:35

Timothy Jones

22.3k6 gold badges65 silver badges95 bronze badges

Collectives™ on Stack Overflow

loop in javascript

2 Answers 2

Comments

Comments

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Related