Python data validation not working as intended

Question

Python 3.8.12

The intended goal of this code is to allow the user to select a "beef", "chicken", "tofu", or "none" sandwich. If the user does not enter one of those options, it will prompt them again to select a sandwich. If they do enter one of these options, then it will continue on with the code.

It is not working properly. It will not accept any input, valid or not. All input causes the program to prompt the user again, rather then moving on with the program if it is valid.

sandwich_choice = input("Select sandwich: ")
while sandwich_choice != "chicken" or sandwich_choice != "beef" or sandwich_choice != "tofu" or sandwich_choice != "none":
    sandwich_choice = input("\x1b[30;41m[!]\x1b[0mSelect sandwich: ")
else:
    pass
print("Sandwich selection is", sandwich_choice)

Even better is while sandwich_choice not in ('chicken','beef','tofu','none'):, and of course you don't need the else clause at all. — Tim Roberts
– Tim Roberts, Commented Feb 28, 2022 at 0:32

Carl_M · Accepted Answer · 2022-02-28 00:35:59Z

1

With modified logic:

sandwich_choice = input("Select sandwich: ")
while sandwich_choice not in ('chicken', 'beef', 'tofu', 'none'):
    sandwich_choice = input("\x1b[30;41m[!]\x1b[0mSelect sandwich: ")
else:
    pass
print("Sandwich selection is", sandwich_choice)

answered Feb 28, 2022 at 0:35

Carl_M

9582 gold badges8 silver badges15 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Aryman Deshwal · Accepted Answer · 2022-02-28 00:34:18Z

1

A better way would be:

sandwich_choice = ""
while True:
   sandwich_choice = input("blah blah blah")
   if sandwich_choice == "beef" or sandwich_choice == "chicken" or sandwich_choice == "tofu" or sandwich_choice == "none":
       break
print("Sandwich selection is",sandwich_choice)

answered Feb 28, 2022 at 0:34

Aryman Deshwal

1751 silver badge11 bronze badges

Comments

Damini Suthar · Accepted Answer · 2022-02-28 00:42:12Z

1

You can try with

 sandwich_choice = input("Select sandwich: ")
    list_sandwich = ['chicken', 'beef', 'tofu', 'none']
    while sandwich_choice not in list_sandwich:
        sandwich_choice = input("\x1b[30;41m[!]\x1b[0mSelect sandwich: ")
    else:
        pass
    print("Sandwich selection is", sandwich_choice)

answered Feb 28, 2022 at 0:42

Damini Suthar

1,4902 gold badges18 silver badges45 bronze badges

Comments

diamondpy · Accepted Answer · 2022-02-28 01:04:09Z

1

Based on Carl_M's implementation

sandwich_choice = input("Select sandwich: ")
while sandwich_choice not in ('chicken', 'beef', 'tofu', 'none'):
        sandwich_choice = input("\x1b[30;41m[!]\x1b[0mSelect sandwich: ")
else:
        print("Sandwich selection is", sandwich_choice)

answered Feb 28, 2022 at 1:04

diamondpy

235 bronze badges

Collectives™ on Stack Overflow

Python data validation not working as intended

4 Answers 4

Comments

Comments

Comments

Comments

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

Comments

Comments

Comments

Comments

Related