Jquery function return value

Question

I've created a function to iterate through a UL/LI. This works perfectly, my problem is returning the value to another variable. Is this even possible? What's the best method for this? Thanks!

function getMachine(color, qty) {
    $("#getMachine li").each(function() {
        var thisArray = $(this).text().split("~");
        if(thisArray[0] == color&& qty>= parseInt(thisArray[1]) && qty<= parseInt(thisArray[2])) {
            return thisArray[3];
        }
    });

}

var retval = getMachine(color, qty);

It's possible and that's how I would do it. Are you not getting a value returned? — Jason Kaczmarsky
– Jason Kaczmarsky, Commented Jul 28, 2011 at 14:56
Your code seems correct, are you able to run Firebug and see if the Console lists anything? — karllindmark
– karllindmark, Commented Jul 28, 2011 at 14:56
return won't work this way in $.each. return will just exit the foreach loop. — codeandcloud
– codeandcloud, Commented Jul 28, 2011 at 15:00
This doesn't work because return thisArray[3] only returns from the .each() inner function, it doesn't return from the getMachine function. As other posters have shown, you need to set thisArray[3] to a local variable and return(false) from the inner function to stop the .each() iteration and then you can return that inner variable from getMachine. — jfriend00
– jfriend00, Commented Jul 28, 2011 at 15:03
Return should actually be false or true for an $.each(). Where false is like a break and true is like a continue. — scottheckel
– scottheckel, Commented Jul 28, 2011 at 15:03

Alex Turpin · Accepted Answer · 2011-07-28 15:39:24Z

54

I'm not entirely sure of the general purpose of the function, but you could always do this:

function getMachine(color, qty) {
    var retval;
    $("#getMachine li").each(function() {
        var thisArray = $(this).text().split("~");
        if(thisArray[0] == color&& qty>= parseInt(thisArray[1]) && qty<= parseInt(thisArray[2])) {
            retval = thisArray[3];
            return false;
        }
    });
    return retval;
}

var retval = getMachine(color, qty);

edited Jul 28, 2011 at 15:39

answered Jul 28, 2011 at 14:57

Alex Turpin

47.9k23 gold badges118 silver badges146 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Milimetric · Accepted Answer · 2011-07-28 17:20:29Z

19

The return statement you have is stuck in the inner function, so it won't return from the outer function. You just need a little more code:

function getMachine(color, qty) {
    var returnValue = null;
    $("#getMachine li").each(function() {
        var thisArray = $(this).text().split("~");
        if(thisArray[0] == color&& qty>= parseInt(thisArray[1]) && qty<= parseInt(thisArray[2])) {
            returnValue = thisArray[3];
            return false; // this breaks out of the each
        }
    });
    return returnValue;
}

var retval = getMachine(color, qty);

edited Jul 28, 2011 at 17:20

answered Jul 28, 2011 at 14:58

Milimetric

13.5k4 gold badges49 silver badges57 bronze badges

1 Comment

Sanghyun Lee Over a year ago

You need to add return false; inside of if statement to break from each() after the assignment.

Collectives™ on Stack Overflow

Jquery function return value

2 Answers 2

Comments

1 Comment

Linked

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

1 Comment

Linked

Related