How to not repeat myself in a loop python

Question

I am learning how to use do not repat yourself principle (https://en.wikipedia.org/wiki/Don%27t_repeat_yourself) in Python.

See my block of code below:

        for key, value in my_dictionary.items():
            if "," in value:
                if key != value:
                    raise ValueError(f"This is my error !")
            else:
                if key != value + ",00":
                    raise ValueError(f"This is my error !")

You can see that I repeat the part raise ValueError(f"This is my error !") two times. Is it posible to use it only once? I tried to use for/else method, but I got lost. Thank you very much for help.

You're interpreting DRY far too literally. It's about redundant data storage; it doesn't literally mean "never type the same sequence of characters ever". — Silvio Mayolo
– Silvio Mayolo, Commented Jun 9, 2021 at 13:44

Jan · Accepted Answer · 2021-06-09 13:59:42Z

3

You could use

for key, value in my_dictionary.items():
    if ("," in value and key != value) or (key != value + ",00"):
        raise ValueError(f"This is my error !")
    
    # everything seems to be fine
    # do sth. useful here

edited Jun 9, 2021 at 13:59

answered Jun 9, 2021 at 13:46

Jan

43.3k11 gold badges57 silver badges87 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

How to not repeat myself in a loop python

1 Answer 1

Comments

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Related