Python, how to alter a method of another class' instance

Question

I would like to add some small functionality to a method of another class' instance. What I tried is listed below. With the same approach it's possible to completely change the method. But I would like to keep a slightly altered version of the original method. Is that possible?

BTW: The classes can not inherit from one another, because I don't necessarily know what class B is.

class A:
    def alter_fn(self, obj):
        def wrapper():
            func = getattr(obj, obj.fn_name)
            out = func()
            print('out = ', out)
            return out
        setattr(obj, obj.fn_name, wrapper)
        return

class B:
    def __init__(self) -> None:
        self.fn_name = 'fn'

    def fn(self):
        return 123


a=A()
b=B()

a.alter_fn(b)
b.fn()

For obvious reasons this raises a recursion depth error but I do not know how to avoid that. I also tried func = copy(getattr(obj, obj.fn_name))

After altering the method b.fn I would like it to return the value, the unaltered function would return (here 123) but I would also like it to do something else with this output, in this example print it.

timgeb · Accepted Answer · 2021-03-10 08:09:38Z

1

Move the assignment of func above the definition of wrapper.

...
def alter_fn(self, obj):
    func = getattr(obj, obj.fn_name)
    def wrapper():
        ...

This way getattr is called only once and wrapper can access func as a closure variable.

answered Mar 10, 2021 at 8:09

timgeb

79.1k20 gold badges129 silver badges150 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Yehla Over a year ago

Yes, now it's obvious. Had a brain-freeze ^^. Thanks

arhr · Accepted Answer · 2021-03-10 08:09:58Z

1

You just need to take the func = getattr(obj, obj.fn_name) out of the wrapperfunction.

class A:
    def alter_fn(self, obj):
        func = getattr(obj, obj.fn_name)
        def wrapper():
            out = func()
            print('out = ', out)
            return out
        setattr(obj, obj.fn_name, wrapper)
        return

answered Mar 10, 2021 at 8:09

arhr

1,64110 silver badges16 bronze badges

1 Comment

Yehla Over a year ago

Thanks, you're right. I chose the other answer because he was a little bit faster (I hope).

mousetail · Accepted Answer · 2021-03-10 08:10:13Z

You need to get the wrapped function before re-assigning it:

def alter_fn(self, obj):
    func = getattr(obj, obj.fn_name)
    def wrapper():
        out = func()
        print('out = ', out)
        return out
    setattr(obj, obj.fn_name, wrapper)
    return

This way func is assigned only once, when the original function is called. Thus, you can safely call it without calling wrapper() again by accident.

Also consider using functools.wraps() to keep the docstring and name information of the string the same.

Collectives™ on Stack Overflow

Python, how to alter a method of another class' instance

3 Answers 3

1 Comment

1 Comment

Comments

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

1 Comment

1 Comment

Comments

Related