Writing nested loop as list comprehension

Question

I have the following for loop I need to make Pythonic by using a list comprehension:

accounts_list = []
for a in Accounts:
    rows = {
            'Account': a["FullyQualifiedName"],
            'Classification': a["Classification"],
            'AccountType': a['AccountType']
            }
    accounts_list.append(rows)
accounts_df = pd.DataFrame(accounts_list)

[{ 'Account': a["FullyQualifiedName"], 'Classification': a["Classification"],'AccountType':a['AccountType'] } for a in Accounts] — Epsi95
– Epsi95, Commented Feb 24, 2021 at 13:35
While @Epsi95's approach is correct, I wouldn't really call it pythonic, I believe keeping things as they are is cleaner than using list comprehension in this case. It just makes it hard to read and results in a line length > 80 characters — Galunid
– Galunid, Commented Feb 24, 2021 at 13:39
"I need to make Pythonic by using a list comprehension:" Pythonic != use list comprehensions — juanpa.arrivillaga
– juanpa.arrivillaga, Commented Feb 24, 2021 at 13:54

Red · Accepted Answer · 2021-02-24 16:25:32Z

1

Here is how:

accounts_list = [{'Account': a["FullyQualifiedName"],
                  'Classification': a["Classification"],
                  'AccountType': a['AccountType']} for a in Accounts]
accounts_df = pd.DataFrame(accounts_list)

Explanation:

This is a basic list comprehension:

[a for a in Accounts]

where the returned value of [a for a in Accounts] is the same as Accounts, if rows is of type list.

Add the dictionary for each iteration, and get

accounts_list = [{'Account': a["FullyQualifiedName"],
                  'Classification': a["Classification"],
                  'AccountType': a['AccountType']} for a in Accounts]

edited Feb 24, 2021 at 16:25

answered Feb 24, 2021 at 13:41

Red

27.7k8 gold badges44 silver badges63 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

Tom Woods Over a year ago

"rows" is a dictionary defined in the for loop though. I think that's where I'm getting stuck

Red Over a year ago

@TomWoods Updated.

Alain T. · Accepted Answer · 2021-03-10 22:48:03Z

0

You could prepare a key mapping list and use it to build your target list items:

 keyMap = [ ['Account','FullyQualifiedName'],
            ['Classification']*2, ['AccountType']*2 ]

 accounts_list = [ {k:a[v] for k,v in keyMap} for a in Accounts ]

answered Mar 10, 2021 at 22:48

Alain T.

42.2k4 gold badges36 silver badges57 bronze badges

Collectives™ on Stack Overflow

Writing nested loop as list comprehension

2 Answers 2

2 Comments

Comments

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

2 Comments

Comments

Related