how to make file path as a global variable in python?

Question

I've been getting this error NameError: name 'filep' is not defined i need to make filep as a file path. but every time i run my code i always get this error.

i need to make the filep as a module variable instead of a parameter as well as menulist.

import csv

filep= # filepath
menulist = [] #global scope


def menu_List():

    global menulist 
    menulist = []  # store items
    try:
        with open(filep) as f:  # read file
            reader = f.readlines()
            next(reader, None) #skip the header

            for row in reader:
                row[2] = int(row[2].strip()) #convert string to int
                row[1] = float(row[1].strip()) #convert string to float
                if row[2] > 100 and row[2] < 200:
                    menulist.append(row)
    except NameError:
        raise ValueError("Variable not set")

    menulist.sort(key=lambda x: x[-1])

menu_List()

You shouldn't be using global variables like this to begin with — juanpa.arrivillaga
– juanpa.arrivillaga, Commented May 29, 2020 at 0:43

Guimoute · Accepted Answer · 2020-05-29 00:41:38Z

You do not need global variables here, your function should accept the path as an argument and return the menu list.

import csv

def menu_List(filep):

    menulist = []  # store items
    try:
        with open(filep) as f:  # read file
            reader = f.readlines()
            next(reader, None) #skip the header

            for row in reader:
                row[2] = int(row[2].strip()) #convert string to int
                row[1] = float(row[1].strip()) #convert string to float
                if row[2] > 100 and row[2] < 200:
                    menulist.append(row)
    except NameError:
        raise ValueError("Variable not set")

    menulist.sort(key=lambda x: x[-1])
    return menulist

menulist = menu_List("a/path/goes/here")

Unrelated to your question, you can skip the header like you did or like this:

reader = f.readlines()
for row in reader[1:]: # skip the first line.
    ...

what i wan is to make the filep as a module variable, i don't need to make it as an argument
Then you just write filep = "a/path/goes/here" at the top of your module and replace the last line by menulist = menu_List(filep). You don't need arguments but it's a good practice to use them.

okie · Accepted Answer · 2020-05-29 00:45:47Z

The answer above (which use args for fliep) is the best solution, but if you determined to not use args:

filep= 'file path you want'# filepath
menulist = [] #global scope


def menu_List():
    global filep #just add one more global will make it work
    global menulist 
    menulist = []  # store items
    try:
        with open(filep) as f:  # read file
            reader = f.readlines()
            next(reader, None) #skip the header

            for row in reader:
                row[2] = int(row[2].strip()) #convert string to int
                row[1] = float(row[1].strip()) #convert string to float
                if row[2] > 100 and row[2] < 200:
                    menulist.append(row)
    except NameError:
        raise ValueError("Variable not set")

    menulist.sort(key=lambda x: x[-1])

menu_List()

Extra little tip: Try prevent using global var if you can, global var slow down program's speed and eats memory, also sometime causing messy var naming.

Hi, i've used that solution already and i need to find another way. anyways thanks :)

Collectives™ on Stack Overflow

how to make file path as a global variable in python?

2 Answers 2

3 Comments

1 Comment

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

3 Comments

1 Comment

Related