Foreach multiple variables

Question

I use the PHP variable $sku to remove certain products from the export. The code below works good if I only want to remove the product with SKU X from the export.

foreach ($skus as $key => $sku){if ($sku == "X") return "";

But if I want to remove products with SKU X and/or Y and/or Z from the export, the code below gives empty output. Any idea what is the issue here?

foreach ($skus as $key => $sku){if ($sku == "X" || $sku == "Y" || $sku == "Z") return "";

Update: I have changed the function, but now I am getting Fatal error: 'continue' not in the 'loop' or 'switch' context in your code on line 32 (continue;).

function get_order_item_lines($skus = '', $qty = ''){
    
    $xml = '';
    if (!empty($skus) && is_array($skus)){
        
        foreach ($skus as $key => $sku){
            if (strpos(strtoupper($sku, "Z")) === 0) return "";
            $xml .= "<L>".PHP_EOL;
            $xml .= "<P>" . $sku . "</P>".PHP_EOL;
            $xml .= "<Q>" . (empty($qty[$key]) ? "" : $qty[$key]) . "</Q>".PHP_EOL;
            $xml .= "</L>".PHP_EOL;
        }

    } else {
        $skus = explode( ",", $skus );
        if ( !empty( $skus[0] ) && !empty( $qty[0] ) ) {
            if (strpos(strtoupper($skus[0], "Z")) === 0) return "";
            $xml .= "<L>".PHP_EOL;
            $xml .= "<P>" . trim( $skus[0] ) . "</P>".PHP_EOL;
            $xml .= "<Q>" . (empty($qty[0]) ? "" : $qty[0]) . "</Q>".PHP_EOL;
            $xml .= "</L>".PHP_EOL;
        }
    }

    return $xml;
}

What have you tried to debug the problem?

Nico Haase
– Nico Haase

2020-07-17 07:21:24 +00:00
Commented Jul 17, 2020 at 7:21 — Nico Haase
– Nico Haase, Commented Jul 17, 2020 at 7:21

Chris Medina · Accepted Answer · 2020-05-19 10:07:50Z

2

Pay attention to the return , do not return (leave the function) when you mean to continue the foreach iteration. Your code is erroneous in doing this:

foreach ($skus as $key => $sku){
    $sku = strtoupper($sku);
    if ($sku == "X" || $sku == "Y" || $sku == "Z") return "";

The above return ""; leaves the function entirely when it finds a $sku being X, Y, or Z and returns NOTHING. Your question/problem states you get an EMPTY value, that's exactly why. If it finds 1 sku with either X, Y, or Z it's going to RETURN. If all you want to do is continue , then let it continue while skipping X, Y, Z skus.

foreach ($skus as $key => $sku){
  $sku = strtoupper($sku);
  if ( $sku == "X" || $sku == "Y" || $sku == "Z") {
    //ignore these skus and continue foreach
    continue;
  }

  $good_skus[] = $sku;
}

var_dump($good_skus);

edited May 19, 2020 at 10:07

answered May 19, 2020 at 8:20

Chris Medina

3381 silver badge10 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

Sjors Over a year ago

Thanks, I have added strtoupper in both if and else statement, but still empty output. I have added the complete function in the initial post.

Chris Medina Over a year ago

The reason it's returning no value it you're having it return. Replace return with continue

Sjors Over a year ago

Thanks for your help. I have tried to add your code, but I get a fatal error. I have updated the initial post. I am sorry, I am not that skilled..

John Goes · Accepted Answer · 2020-07-17 11:41:59Z

Maybe this will do the trick.

function get_order_item_lines($skus = '', $qty = '')
{
    $xml = '';

    if (!empty($skus) && is_array($skus))
    {
        foreach ($skus as $key => $sku)
        {
            $skuUpper = strtoupper($sku); // change to upper
            
            if ($skuUpper != 'WANHAO-STICKER'
                && strpos($skuUpper, 'NWS-', 0) === false)  // string not contains..
            {
                $xml .= "<L>".PHP_EOL;
                $xml .= "<P>" . $sku . "</P>".PHP_EOL;
                $xml .= "<Q>" . (empty($qty[$key]) ? "" : $qty[$key]) . "</Q>".PHP_EOL;
                $xml .= "</L>".PHP_EOL;
            }
        }
    } 
    else 
    {
        $skus = explode( ",", $skus );

        if ( !empty( $skus[0] ) && !empty( $qty[0] ) ) 
        {
            $skuUpper = strtoupper($skus[0]); // change to upper
            
            if ($skuUpper != 'WANHAO-STICKER'
                && strpos($skuUpper, 'NWS-', 0) === false)
            {
                $xml .= "<L>".PHP_EOL;
                $xml .= "<P>" . trim( $skus[0] ) . "</P>".PHP_EOL;
                $xml .= "<Q>" . (empty($qty[0]) ? "" : $qty[0]) . "</Q>".PHP_EOL;
                $xml .= "</L>".PHP_EOL;
            }
        }
    }

    return $xml;
}

Nigel Ren · Accepted Answer · 2020-05-19 08:35:10Z

1

There are several ways to do this, if the array is more complex you could use array_filter() and use in_array() with an array of the SKU's to remove...

$filteredSkus = array_filter($skus, function ($sku) use ($skusToRemove){
    return !in_array($sku, $skusToRemove);
});

Or if the SKU is simply the value in the array, you can array_diff() with an array of the SKU's to remove...

$difSkus = array_diff($skus, $skusToRemove);

answered May 19, 2020 at 8:35

Nigel Ren

57.2k11 gold badges49 silver badges59 bronze badges

Comments

Samuel Breu · Accepted Answer · 2020-05-19 09:01:15Z

Related to Nigel Ren's answer which is correct in my opinion, here an example to your question:

// remove skus X, Y, and Z
$filteredSkus = array_filter($skus, static function($sku) {
    return !($sku === 'X' || $sku === 'Y' || $sku === 'Z')
});

If you want to filter skus which start with these letters you need to use strpos like that:

// remove skus starting with X, Y, and Z
$filteredSkus = array_filter($skus, static function($sku) {
    return !(
        strpos(strtoupper($sku, 'X')) === 0 ||
        strpos(strtoupper($sku, 'Y')) === 0 ||
        strpos(strtoupper($sku, 'Z')) === 0
    )
});

Collectives™ on Stack Overflow

Foreach multiple variables

4 Answers 4

3 Comments

1 Comment

Comments

Comments

Hot Network Questions