Windows batch script - comparing strings in if statement

Question

I am trying to write a Windows batch script which examines an XML file (the iml file) to search for a certain line, . I am having trouble with the spaces in the string. Is there a way to escape or compensate for the spaces?

for /f "tokens=*" %%a in (abcd.iml) do (
    echo %%a
    if %%a==^<orderEntry type="inheritedJdk" ^> (echo 'FOUND')
 )

You should always use quotes with string comparisons. if "%%a"=="<orderEntry type="inheritedJdk" >" — Squashman
– Squashman, Commented Apr 23, 2020 at 20:25

Nico Nekoru · Accepted Answer · 2020-04-24 01:44:56Z

1

Put the %%a in quotes so it is like "%%a." Instead of using the "==" operator to compare %%a and "^" it would be better to use the EQU comparator so the final code would look like:

for /f "tokens=*" %%a in (abcd.iml) do (
    echo %%a
    if "%%a" EQU "<orderEntry type="inheritedJdk" >" (echo 'FOUND')
 )

For more information on EQU and other operators see https://ss64.com/nt/if.html or https://ss64.com/nt/equ.html

edited Apr 24, 2020 at 1:44

answered Apr 23, 2020 at 20:56

Nico Nekoru

3,2123 gold badges23 silver badges39 bronze badges

Sign up to request clarification or add additional context in comments.

4 Comments

Compo Over a year ago

Neko Musume, I think that you should have read Sqashman's opening comment, and my comment too, because currently, (despite the upvote you've already received) your answer doesn't work as intended.

Nico Nekoru Over a year ago

Oh do you mean the breakout key on the echo? Sorry I never really understood how to use it but I can edit the answer and add it.

Compo Over a year ago

Please read the comments! and obviously if you get the chance test it yourself. It wouldn't take much to test it against any file, renamed accordingly with and without inserting the required string <orderEntry type="inheritedJdk" > on a line.

Nico Nekoru Over a year ago

It already works for me, I've tested it so I don't know what errors you are talking about

Stephan · Accepted Answer · 2020-04-24 18:22:38Z

1

no need for a for loop. A simple findstr is much faster:

 findstr /c:"<orderEntry type=\"inheritedJdk\" >" "abcd.iml" >nul && echo found || echo nope

Note: the quotes within the string have to be escaped (escape character for findstr is a backslash)

edited Apr 24, 2020 at 18:22

answered Apr 24, 2020 at 15:17

Stephan

56.7k11 gold badges66 silver badges97 bronze badges

2 Comments

Nico Nekoru Over a year ago

Wouldn't "findstr" be better for searching for text in files?

Stephan Over a year ago

@NekoMusume findstr is newer and has more options, but find is perfectly fine for some tasks, so newer is not always better. But you are right in this case. The quotes in the string have to be escaped. Find can't do that (my previous find solution ran fine just "by accident" (was satisfied by just <orderEntry type= and ignored the rest)). Changed to findstr.

Collectives™ on Stack Overflow

Windows batch script - comparing strings in if statement

2 Answers 2

4 Comments

2 Comments

Linked

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

4 Comments

2 Comments

Linked

Related