c# Fill multiple arrays with input

Question

I'm trying to fill 3 arrays with user input, it should look like this:

Enter account number 1: 29384
Enter the account balance: 1111
Enter the account holder last name: lastname
Enter account number 2: 34938
Enter the account balance: 2222
Enter the account holder last name: lastname2
Enter account number 3: 46372
Enter the account balance: 3333
Enter the account holder last name: lastname3
and so on...

I have my program set up with for loops to fill a 5 line array but it asks for all five account numbers first then goes onto the balance and so on

using System;
public class Array1
{
    public static void Main()
    {
        int[] scores = new int[5];
        int x;
        string inputString;
        int[] balance = new int[5];
        int y;

        for(x=0; x < scores.Length; ++x)
        {
            Console.Write("Enter account number {0} ", x + 1);
            inputString = Console.ReadLine();
            scores[x] = Convert.ToInt32(inputString);
            }
        for(y=0; y < balance.Length; ++y)
        {
            Console.Write("Enter the account balance ");
            inputString = Console.ReadLine();

            }
    }
}

I'm sure there is a much better way to write this. Any help would be appreciated.

BugFinder · Accepted Answer · 2011-04-02 13:54:43Z

3

Yes.

Why not have a class with a structure

class DataHolder
{
  public String account_number;
  public int balance;
  public String lastname;
}

Then you're at least holding relevant data together

Your code then does as you've instructed, its asked to get all the accounts, then all the balances..

Where as 1 loop would have been sufficient

If you had an array of DataHolder class

DataHolder[] testData = new DataHolder[5];
For (int x=0; < x testData.length; x++)
{
 Console.Write("Account Number");
 testData[x].account_number= Console.ReadLine();
 Console.Write("Balance");
 testData[x].balance=Convert.ToInt32(Console.ReadLine());
 Console.Write("LastName");
 testData[x].lastname=Console.ReadLine();
}

answered Apr 2, 2011 at 13:54

BugFinder

17.9k4 gold badges42 silver badges58 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

Cody Gray Over a year ago

That's not "a class with a structure". That's just a class.

BugFinder Over a year ago

bleh, words. Im dyslexic. It probably should have been a structure, but, I was trying to give a basic example, no you're right in my example it has no structure.

Cody Gray Over a year ago

It should only be a structure if it's immutable. I expect that's probably not the case, and you were right in making it a class in the first place.

neontapir · Accepted Answer · 2011-04-02 13:48:24Z

1

I think you just want one for loop.

for(x=0; x < scores.Length; ++x)
{
        Console.Write("Enter account number {0} ", x + 1);
        inputString = Console.ReadLine();
        scores[x] = Convert.ToInt32(inputString);

        Console.Write("Enter the account balance ");
        inputString = Console.ReadLine();

   // and so on
}

answered Apr 2, 2011 at 13:48

neontapir

4,7643 gold badges40 silver badges53 bronze badges

1 Comment

Steve Over a year ago

+1 Damn it, I'd just typed exactly the same answer... yes, using one loop is the fix required.

Collectives™ on Stack Overflow

c# Fill multiple arrays with input

2 Answers 2

3 Comments

1 Comment

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

3 Comments

1 Comment

Related