Javascript need regex to add to the end of a string

Question

I'm trying to add a variable to the end of my href using regex and jquery. This is what i have so far:

$('#survey-click1').click(function(event) {
      playerPause();
      $("a[href^=http://d.surveysonline.com/]")
          .each(function()
      {
        this.href = [regex goes here];
      });
      return false;
});

I'm simply trying to add a variable at the end of the url i clicked on to attach whether or not the video i just watched had a preroll or not. This could be done easily by attaching this to the end of my url code [&preroll="+Kdp3State.preroll+"]. How do i detect the end of the href string to attach this to to it?

Thanks

Aron Rotteveel · Accepted Answer · 2011-03-16 16:04:04Z

1

Assuming that this is actually what you want to append to your URL, this should work:

$("a[href^=http://d.surveysonline.com/]").each(function() {
    $(this).attr('href', $(this).attr('href', '&preroll='+Kdp3State.preroll);
});

Apart from the fact that you use a CSS selector that is somewhat similiar to a regex, this question seems be unrelated to the subject.

answered Mar 16, 2011 at 16:04

Aron Rotteveel

83.4k17 gold badges106 silver badges129 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Alnitak · Accepted Answer · 2011-03-16 16:16:11Z

1

There's no need for a regexp, just do:

this.href += 'string_to_be_appended';

e.g.

this.href += '&preroll=' + encodeURIComponent(Kdp3State.preroll);

Note the use of encodeURIComponent to ensure that any special characters (+, %, etc) in the resulting URI are correctly encoded.

edited Mar 16, 2011 at 16:16

answered Mar 16, 2011 at 16:04

Alnitak

341k72 gold badges420 silver badges503 bronze badges

5 Comments

Aron Rotteveel Over a year ago

Judging from his code, he is using jQuery. this.href would be invalid in that case. Instead, use this.attr('href')

Alnitak Over a year ago

actually, it looks like I was right. $(selector).each() supplies the underlying elements in this, not a jQuery object.

Aron Rotteveel Over a year ago

Oh, nice :) I didn't actually know that. We learn something new every day, I guess. (still seems pretty odd though)

Alnitak Over a year ago

that's why I hang around here - sometimes you learn a lot from ones own incorrect answers :)

Alnitak Over a year ago

FWIW, from api.jquery.com/each - "the callback is fired in the context of the current DOM element, so the keyword this refers to the element"

w35l3y · Accepted Answer · 2011-03-16 16:05:28Z

0

this.href += "&preroll=" + Kdp3State.preroll

or

this.href = this.href.replace(/&preroll=[^&]+/g, "") + "&preroll=" + Kdp3State.preroll;

?

answered Mar 16, 2011 at 16:05

w35l3y

8,8233 gold badges41 silver badges53 bronze badges

Collectives™ on Stack Overflow

Javascript need regex to add to the end of a string

3 Answers 3

Comments

5 Comments

Comments

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

5 Comments

Comments

Related