ruby output format

Question

I have the following code, which works fine. The problem is that I get the following output:

Device ID: SEP1C17D3415659

IP address: 10.2.3.101

I would like to get:

SEP1C17D3415659 10.2.3.101

Thanks for your help

require 'net/telnet'
require '/apps/dateformat'


@tdate = Formatdate.new.mydate

hosts = %w"SW3"


  hosts.each do |hostname|

        tn = Net::Telnet::new("Host" => "#{hostname}",
                                     "Timeout" => 10000,
                                     "Prompt" => /[$%#>] \z/n)

        tn.cmd('String' =>'user' , 'Match'=>/Password:/) { |c| puts c }
        tn.cmd('String' =>'password', 'Match'=>/#/) { |c| puts c }
        tn.cmd('String' =>'terminal length 0', 'Match'=>/#/) { |c| puts c }


        File.open("/agents/#{hostname}-#{@tdate}-agents.txt",'w') do |o|
            run=tn.cmd('String' =>'sh cd ne de | inc Device ID: | IP address:', 'Match'=>/#/) { |c| puts c }
                        run.each_line do |re|
                        mac = re.match /Device ID: ([\S]+)/
                        #ip = re.match /([\S]+) address/
                        ip = re.match /IP address: ([\S]+)/
                        o.puts mac
                        o.puts ip
                    end




        end

end

o.print " " o.print ip.to_s o.print "\n" o.print mac.to_s

rahrahruby
– rahrahruby

2011-03-15 20:52:03 +00:00
Commented Mar 15, 2011 at 20:52 — rahrahruby
– rahrahruby, Commented Mar 15, 2011 at 20:52

Cody · Accepted Answer · 2011-03-15 19:33:54Z

3

puts automatically prints a new line after each output. Simply put both on the same line.

outputString = mac + " " + ip
o.puts outputString

If you have other output functions available such as print, it will function without putting a newline between the two statements.

edited Mar 15, 2011 at 19:33

answered Mar 15, 2011 at 19:17

Cody

3,7642 gold badges26 silver badges29 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

rahrahruby Over a year ago

findagents.rb:34:in block (3 levels) in <main>': undefined method +' for #<Mat chData "Device ID: |" 1:"|"> (NoMethodError) from findagents.rb:28:in each_line' from findagents.rb:28:in block (2 levels) in <main>' from findagents.rb:26:in open' from findagents.rb:26:in block in <main>' from findagents.rb:15:in each' from findagents.rb:15:in <main>'

Cody Over a year ago

Try: outputString = mac + " " + ip and then o.puts outputString

matt · Accepted Answer · 2011-03-15 20:44:41Z

You're correctly specify the grouping you want for your regular expression, but you're not using it when printing it out.

Your regular expression is:

mac = re.match /Device ID: ([\S]+)/

and this matches the whole line Device ID: SEP1C17D3415659, putting the part you want (SEP1C17D3415659) into a group so you can get at it later. However you then print it out using

o.puts mac

This gives the whole match, not just the group. What you want is this instead:

o.puts mac[1]

which specifies just the group.

Also, as Cody says, puts adds a newline on each call. If you want both matches to print on the same line try something like:

o.print "#{mac[1]} #{ip[1]}\n"

instead.

Edit:

I'm not familiar with net/telnet or the command you're running, but it looks like you're running a certain command, then filtering for certain lines and then printing some info from those lines. If this is the case, then any lines that don't match will give you nil for mac and ip so you'll get "undefind method []" on those lines.

If this is the case you can simply use:

o.print "#{mac[1]} #{ip[1]}\n" unless mac.nil?

You might find it worth while to restructure your code slightly to better express what you're doing, by combining the two regular expressions into one. Without knowing the structure of the actual lines I can't create the real expression you'll need, but it would look something like this:

run.each_line do |line|
  match = line.match /^Device ID: ([\S]+), IP address: ([\S]+)$/ #these are the lines we want
  next unless match #skip lines we don't want
  o.print "#{match[1]} #{match[2]}\n" #print the details we're interested in
end

Thanks for the reply, unfortunately o.print "#{mac[1]} #{ip[1]}\n" produces the following error:
findagents.rb:34:in block (3 levels) in <main>': undefined method []' for nil: NilClass (NoMethodError) from findagents.rb:28:in each_line' from findagents.rb:28:in block (2 levels) in <main>' from findagents.rb:26:in open' from findagents.rb:26:in block in <main>' from findagents.rb:15:in each' from findagents.rb:15:in <main>'
when I run it without the [1] o.print "#{mac} #{ip}\n" the mac and ip output still are on separate lines.
It appears to me that the problem is caused by the loop run.each_line do |re| it does the print for each element every time it hits them

Collectives™ on Stack Overflow

ruby output format

2 Answers 2

2 Comments

5 Comments

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

2 Comments

5 Comments

Related