making associative array - array_combine() expects parameter 1 to be array, string given [duplicate]

Question

I am trying to create an associative array where the first element will represent the headers.

I would like to take this array:

Array
(
    [0] => Name,Phone number
    [1] => John,555666123
    [2] => Bobby McQueen, 556699887
)

And turn it into this array:

Array
(
    [0] => Array
        (
            [Name] => John
            [Phone number] => 555666123
        )

    [1] => Array
        (
            [Name] => Bobby McQueen
            [Phone number] => 556699887
        )
)

Here is my code

$assoc_array = array();
$my_array = explode("\n", file_get_contents($file->getPathName()));

$header = array_shift($my_array);


foreach ($my_array as $row) {
  $assoc_array[] = array_combine($header, $row);
}

But I am getting error:

array_combine() expects parameter 1 to be array, string given

Explode $header by comma. And $row too. Or move to fgetcsv. — u_mulder
– u_mulder, Commented Oct 29, 2018 at 10:38
Have you seen this little guy: php.net/manual/en/function.fgetcsv.php ? — mickmackusa
– mickmackusa ♦, Commented Oct 29, 2018 at 10:45

u_mulder · Accepted Answer · 2018-10-29 10:56:19Z

2

$assoc_array = array();
$my_array = explode("\n", file_get_contents($file->getPathName()));

$header = array_shift($my_array);
// $header is a string now "Name,Phone number"
// make it array:
$header = explode(",", $header);

foreach ($my_array as $row) {
  // $row is a string too, and should be exploded
  $assoc_array[] = array_combine($header, explode(',', $row));
}

But as already mentioned in comments - use fgetcsv, it has some features that your current code does not implement. It also reduces lines of code.

answered Oct 29, 2018 at 10:56

u_mulder

54.8k5 gold badges54 silver badges72 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Death-is-the-real-truth · Accepted Answer · 2018-10-30 04:19:11Z

1

You need to explode() $header and $row both by ,

$header = explode(',',array_shift($my_array));//convert header into array


foreach ($my_array as $row) {
  //combine header and $row which also become an array after explode()
  $assoc_array[] = array_combine($header, explode(','$row));
}

edited Oct 30, 2018 at 4:19

answered Oct 29, 2018 at 10:48

Death-is-the-real-truth

72.3k10 gold badges58 silver badges105 bronze badges

Collectives™ on Stack Overflow

making associative array - array_combine() expects parameter 1 to be array, string given [duplicate]

2 Answers 2

Comments

Comments

Linked

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Linked

Related