Android - Unable to call methods defined in ViewModel

Question

I'm trying to call a method that I've created in my ViewModel class but I'm not able to access it in my MainActivity where I've initialized my ViewModel.

This is my ViewModel class

public class MovieViewModel extends AndroidViewModel {

private MovieRepository movieRepository;
public List<Movie> movieList;

public MovieViewModel(@NonNull Application application) {
    super(application);
    movieRepository = new MovieRepository();
}

public List<Movie> getMovieList(String sortChoice, int pageNumber) {
    movieList = movieRepository.getMovieList(sortChoice,pageNumber);
    return movieList;
}
}

This is part of MainActivity

    private ViewModel mViewModel;
    @Override
    protected void onCreate(Bundle savedInstanceState) {
        super.onCreate(savedInstanceState);
        binding = DataBindingUtil.setContentView(this, R.layout.activity_main);
        pageNumber = 1;
        sharedPref = this.getPreferences(Context.MODE_PRIVATE);
        String defaultSort = MovieConstants.POPULAR;
        choiceOfSorting = sharedPref.getString(PREF_SORT_KEY, defaultSort);

        mViewModel = ViewModelProviders.of(this).get(MovieViewModel.class);
`

When I try calling the method getMovieList with the line

mViewModel.getMovieList(someVariable, someVariable);

it shows in red saying - Cannot resolve symbol 'getMovieList'

you are saving viewmodel in ViewModel instance, use MovieViewModel instead — Qasim
– Qasim, Commented Aug 28, 2018 at 13:57

PPartisan · Accepted Answer · 2018-08-28 13:56:53Z

2

You're assigning ViewModelProviders.of(this).get(MovieViewModel.class); to a variable of the base type ViewModel, so you will only be able to access methods available in ViewModel.

Replace private ViewModel mViewModel; with private MovieViewModel mViewModel;

answered Aug 28, 2018 at 13:56

PPartisan

8,2614 gold badges31 silver badges51 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Zun · Accepted Answer · 2018-08-28 13:56:40Z

1

private ViewModel mViewModel;

ViewModel doesn't have getMovieList, so change that to

private MovieViewModel viewModel;

answered Aug 28, 2018 at 13:56

Zun

1,7313 gold badges18 silver badges29 bronze badges

Comments

Ricardo Costeira · Accepted Answer · 2020-01-09 16:11:31Z

1

Your mViewModel is of type ViewModel, which has no method called getMovieList. Change the type to MovieViewModel.

edited Jan 9, 2020 at 16:11

answered Aug 28, 2018 at 13:56

Ricardo Costeira

3,3312 gold badges25 silver badges24 bronze badges

Collectives™ on Stack Overflow

Android - Unable to call methods defined in ViewModel

3 Answers 3

Comments

Comments

Comments

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

Comments

Comments

Related