mysql query not inserting to database

Question

i have a db query in php that is not inserting into database. Have used this format lots of times but for some reason its not working now. any ideas please

    $query = "INSERT INTO `databasename`.`member_users` (`id`, `first_name`, `last_name`, `username`, `password`, `address1`, `address2`, `postcode`, `access`, `expires`) VALUES (NULL, '$fname', '$lname', '$email', '', '$add1', '$add2', '$postcode', '0', '')";
$result = mysql_query($query);
if($result){
    echo"query inserted";

}else{

    echo "nope";
}

As Pekka says, check mysql_error(). Change your echo "nope"; to echo mysql_error();, which will give you the exact reason the query's failing. Just saying 'nope' is useless. — Marc B
– Marc B, Commented Mar 2, 2011 at 16:40
$postcode = "abc', '0', ''); DROP TABLE databasename.member_users; --" — Arthur
– Arthur, Commented Mar 2, 2011 at 16:40
think i have solved. If the form uses auto insert from previous data (i.e. chrome save details) it does not work. i have no idea why this is — nead93
– nead93, Commented Mar 2, 2011 at 16:41
To clarify @Tyler's comment, the fact that you "Have used this format lots of times" is downright scary. This is wide open to an attack called "SQL Injection" (google it) and is the MOST insecure way to write database statements. It is trivial for someone to write a URL that can destroy your database, or harvest its contents unfiltered. PLEASE read up on SQL Injection and change your ways. — Jim Garrison
– Jim Garrison, Commented Mar 2, 2011 at 16:43

krtek · Accepted Answer · 2011-03-02 16:41:34Z

2

Instead of echo "nope"; I suggest something like :

echo 'error while inserting : ['.mysql_errno().'] '.mysql_error();
echo 'query : '.$query;

This way you will be able to see the exact error and the query that was executed.

It can be a lot of things :

Constraint error with a foreign key
Data type error
Non-existent field
Wrong database or table name

answered Mar 2, 2011 at 16:41

krtek

26.7k5 gold badges60 silver badges84 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

nead93 Over a year ago

think i have solved. If the form uses auto insert from previous data (i.e. chrome save details) it does not work. i have no idea why this is

axel22 · Accepted Answer · 2011-05-25 19:17:46Z

0

Instead of...

$query = "INSERT INTO `databasename`.`member_users` ..."

do

$query = "INSERT INTO member_users ..."

Hope it works. :)

edited May 25, 2011 at 19:17

axel22

32.4k10 gold badges127 silver badges139 bronze badges

answered May 25, 2011 at 2:34

royrui

1,21710 silver badges20 bronze badges

Comments

Akshay · Accepted Answer · 2012-11-06 06:44:49Z

0

If databasename and member_users are variables then, Instead of $query = "INSERT INTO databasename.member_users... do $query = "INSERT INTO $databasename.$member_users...

answered Nov 6, 2012 at 6:44

Akshay

1,9011 gold badge19 silver badges22 bronze badges

Collectives™ on Stack Overflow

mysql query not inserting to database

3 Answers 3

1 Comment

Comments

Comments

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

1 Comment

Comments

Comments

Related