6

I want to implement a simple Cache interface:

public interface Cache {
    Object get(Object key);
    Object put(Object key, Object value);
    void clear();
}

I realized it's part of interface java.util.Map. So objects like HashMap should be able to be be passed to functions needing a Cache object.

But on the other hand I don't want to make my own Cache class implement the whole Map interface because I don't really need other methods other than these three.

Java is not a duck-typed language, so what's the best practice in this situation?

12
  • 2
    Implement all methods, because you have to; make the methods you aren't planning to invoke throw UnsupportedOperationException. Commented May 8, 2018 at 18:10
  • 3
    The only purpose of Interfaces is to enforce a class implements certain methods. Commented May 8, 2018 at 18:11
  • 1
    add deprecited flag to the method you are not planning to invoke Commented May 8, 2018 at 18:15
  • 1
    @Stephan Yes. What I can do now is to make a wrapper Cache class which accept a Map object as single parameter. And implements all there method by calling the internal Map object. Commented May 8, 2018 at 18:22
  • 2
    I would personally make my own Cache interface and implement that. You shouldn't have a class implement Map unless it's a map. Commented May 8, 2018 at 18:27

3 Answers 3

2

There are no such features in java.

I think the best you can do is to create a wrapper of HashMap as you concern.

An interface is a contract. The implemented class should fullfill the contract by implement the virtual / abstract methods.

Your CacheImpl only fullfills the contract with Cache interface. Meanwhile HashMap only fullfills the contract with Map interface.

The Cache and Map interface share method with same signatures but they requires different contract / implementation.

You really can not determine if an interface contains the method Object put(Object key, Object value); is compatible with your Cache interface or not, because you don't understand which contract that interface provide.

So in Java, unless they provide semantic to create kind of "parent" interface of existing interface, you cannot do that.

Sign up to request clarification or add additional context in comments.

Comments

2

I think you can wrapper Map inside the Implementation of Cache class

class CacheImpl<K, V> implements Cache<K, V> {
    Map<K, V> cacheMap;

    CacheImpl() {
        this(new LinkedHashMap<>());
    }

    CacheImpl(Map<K,V> cacheMap) {
        this.cacheMap = cacheMap;
    }

    @Override
    public V get(K key) {
        return cacheMap.get(key);
    }

    @Override
    public V put(K key, V value) {
        return cacheMap.put(key, value);
    }

    @Override
    public void clear() {
        cacheMap.clear();
    }
}

I have added the example with the Generic but you are always free to Use Object as the key and value.

So, in my example to make it thread safe We can we ConcurrentHashMap which is already thread safe and well implemented. I will suggest having a Factory class to create the cache object like below.

class CacheImplFactory {
    public static <K, V> Cache<K, V> newSimpleCache() {
        return new CacheImpl<K, V>();
    }

    public static <K, V> Cache<K, V> newSynchronizedCache() {
        return new CacheImpl<K, V>(new ConcurrentHashMap<>());
    }

    public static <K, V> Cache<K, V> newWeakCache() {
        return new CacheImpl<K, V>(new WeakHashMap<>());
    }
}

7 Comments

The map should be passed in rather than instantiated in the constructor. Otherwise, great answer.
Good, but no thread safety considerations at all. This class is a memory leak waiting to happen. HashMap will work, but I'd prefer something that kicked out long lived objects using LRU in LinkedHashMap. stackoverflow.com/questions/224868/…
@shmosel Thanks!!! Yes, you are right it will make loosely coupled code and testable code. I will improve my answer.
I like the idea of a wrapper class. However, personally I would implement it as a static method of Cache returning an anonymous class.
Don't use raw generics. Change constructor parameter to Map<K, V>. You should also add @Override annotations to the methods implementing the interface.
|
1

If I understand your question, you're asking how to back the interface with an existing java class like HashMap.

You will have to create your own implementation that implements your interface, and extends HashMap.

The Interface methods will delegate the action to the HashMap. In this manner, your custom class will meet the interface needs for any Method with a signature of your interface.

A working example I threw together to showcase how to do what you're asking with Generics:

The Cache Interface:

package interfaces;

public interface Cache<K,V> {
    V get(K key);
    V put(K key, V value);
    void clear();
}

The Implementation:

package classes;

import java.util.HashMap;
import interfaces.Cache;

public class MyCache<K,V> extends HashMap<K,V> implements Cache<K,V> {

    private static final long serialVersionUID = 1L;

    @Override
    public V get(Object key) {
        return super.get(key);
    }

    @Override
    public V put(K key, V value) {
        return super.put(key, value);
    }

    @Override
    public void clear() {
        super.clear();
    }
}

You can then use it like so:

import classes.MyCache;
import interfaces.Cache;

public class DoStuff {

    private Cache<String,Integer> cache;

    public void initCache() {
        //This works
        //Since MyCache implements Cache
        MyCache<String,Integer> mCache=new MyCache<String,Integer>();
        setCache(mCache);

        //This will not
        //Since HashMap does not implement Cache
        HashMap<String,Integer> mMap=new HashMap<String,Integer>();
        setCache(mMap);
    }

    public void setCache(Cache<String,Integer> c) {
        cache=c;
    }

    public Cache<String,Integer> getCache() {
        return cache;
    }
}

2 Comments

OP want to pass exactly a HashMap to method that accept a Cache interface
Added a bit to the example to show why that's not possible

Start asking to get answers

Find the answer to your question by asking.

Ask question

Explore related questions

See similar questions with these tags.