Variable inside of variable

Question

So, I'm trying to write a batch file that will take my input, slot it into a template that I've created, and put that into a text file.

set Output="%USERPROFILE%\desktop"

set /p VarOne=Example

echo ** %VarOne% ** > %Output%\%date:~-10,2%%date:~-7,2%%date:~-4,4%.txt

This works fine, but if I do it like this, I get an access denied error:

set Output="%USERPROFILE%\desktop"
set FNAME="%Output%\%date:~-10,2%%date:~-7,2%%date:~-4,4%.txt"

set /p VarOne=Example

echo ** %VarOne% ** > %FNAME%

I'm pretty inexperienced so, forgive me if its obvious.

No error on my system - Windows 10 - what version are you running? — dbmitch
– dbmitch, Commented Apr 30, 2018 at 21:20
Don't assign double quotes to your variables. Only use the double quotes when you are using the variable. Remove the quotes from the output and FNAME variables. Then your last line should be echo ** %VarOne% ** > "%FNAME%" — Squashman
– Squashman, Commented Apr 30, 2018 at 21:25

Squashman · Accepted Answer · 2018-04-30 21:49:20Z

3

Don't assign double quotes to your variables but do use them to quote the SET statement as a best practice to protect special characters.

set "Output=%USERPROFILE%\desktop"
set "FNAME=%Output%\%date:~-10,2%%date:~-7,2%%date:~-4,4%.txt"

set /p VarOne=Example

echo ** %VarOne% ** >"%FNAME%"

answered Apr 30, 2018 at 21:49

Squashman

14.4k5 gold badges30 silver badges38 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

Variable inside of variable

1 Answer 1

Comments

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Related