How to declare the controller in angularjs

Question

I had one question during interviews.

"Which of the following code snippets is more efficient?"

AppModule.controller('homeController', ['$scope', 'dep1', 'dep2', function($scope, dep1, dep2) {
...
    $scope.aMethod = function() {
       ...
    }
...
}]);

AppModule.controller('homeController', function($scope, dep1, dep2) {
...
    $scope.aMethod = function() {
        ...
    }
...
});

• Both are equally efficient.

• The second code is more efficient as it contains less code.

• The first code is more efficient because it holds names of dependencies.

• The second code is more efficient because it not contains additional an array.

I think the 3rd answer is right but not sure I'm right.

Please help me.

None of the above. Read this : github.com/johnpapa/angular-styleguide/blob/master/a1/… — Pritam Banerjee
– Pritam Banerjee, Commented Mar 28, 2018 at 8:01
The second will work as the first one if you inject separately: homeController.$inject = ['$scope', 'dep1', 'dep2']; — Aleksey Solovey
– Aleksey Solovey, Commented Mar 28, 2018 at 8:14

Bk Santiago · Accepted Answer · 2018-03-28 08:02:31Z

2

The first one will work as expected after applying some uglification/minification while the second one won't work after that since the variable names will change during this process and angularjs will have no way to know what to inject since the variable names changed.

answered Mar 28, 2018 at 8:02

Bk Santiago

1,5733 gold badges13 silver badges25 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Shohel · Accepted Answer · 2018-03-28 08:12:05Z

1

Third is right, Because when you will uglification/minification the code by using any task runner then angular have no way to know the dependency. so third is better.

answered Mar 28, 2018 at 8:12

Shohel

3,9645 gold badges41 silver badges80 bronze badges

Collectives™ on Stack Overflow

How to declare the controller in angularjs

2 Answers 2

Comments

Comments

Linked

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Linked

Related