"pre-commit" not running in Linux

Question

I believe this should work as pre-commit will run anything defined in scripts.

  "scripts": {
    "lint": "lint-staged",
  }, 
  "pre-commit": [
    "lint"
  ],
  "lint-staged": {
    "*.js": [
      "prettier --write",
      "eslint",
      "git add"
    ],
    "*.jsx": [
      "prettier --write",
      "eslint",
      "git add"
    ],
    "*.scss": [
      "stylelint --syntax=scss",
      "git add"
    ]
  },

Console with link not running

hutber@hutber-blade /var/www/shipamax-web/frontend $ git add tests/
hutber@hutber-blade /var/www/shipamax-web/frontend $ git commit -m"another test"
[chore/create-circleci-build-rebase 5ff3f76] another test
 1 file changed, 1 insertion(+), 1 deletion(-)
hutber@hutber-blade /var/www/shipamax-web/frontend $

Folder Structure

- /.git
- /frontend
--all fe code
--package.json

Running
Linux Mint 18.3
node v8
npm v5

[Edit]

Post running npm install pre-commit -D inside of ./frontend

Folder structure

so I removed npm pre-commit and created a pre-commit file inside /.git/hooks just to see if it would rename the file, no such luck:

and pre-commit is in your devDependency? The page for pre-commit says that it modifies .git/hooks/pre-commit and moves the old one to .git/hooks/pre-commit.old -do you see those files? — Kevin Hoerr
– Kevin Hoerr, Commented Feb 14, 2018 at 14:41
did you manually add pre-commit to your dependencies in package.json? You probably have to use npm to install it so it knows to add those hooks to your git package. Run npm install --save-dev pre-commit so it installs correctly — Kevin Hoerr
– Kevin Hoerr, Commented Feb 14, 2018 at 22:00
Just tried this and have updated my question to show the findings, but it did not solve my issues — Jamie Hutber
– Jamie Hutber, Commented Feb 15, 2018 at 10:10

VonC · Accepted Answer · 2018-02-20 20:48:13Z

1

As long as you don't see a .git/hooks/pre-commit file created by npm install --save-dev pre-commit (from the npm pre-commit package), you won't get any pre-commit action.

From the observing/pre-commit/install.js check the logs to see if the plugin does detect your .git folder (and if it is the right one)

console.log('pre-commit:');
console.log('pre-commit: Found .git folder in', git);

answered Feb 20, 2018 at 20:48

VonC

1.4m568 gold badges4.8k silver badges5.7k bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Jamie Hutber Over a year ago

I will have to check the logs, I'll report back, thanks

Collectives™ on Stack Overflow

"pre-commit" not running in Linux

1 Answer 1

1 Comment

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

1 Comment

Related