parameterize a jquery function

Question

i m having a jquery animate function to animate a list which is specified using

    $li = $("ol#update > li");

the animate function

function animate_li()
{
   $li.filter(':first')
      .animate({
         height:  'show',
         opacity: 'show'
      }, 250, function(){
        animate_li();
      });
    $li = $li.not(':first');
}

now i want to parameterize the animate_li function which i have done as:

function sp_animate_li(sp)
{
    console.log ( $li );
    function animate_li()
    {
        $li.filter(':first')
        .animate({
         height:  'show',
         opacity: 'show'
        }, sp, function(){
            animate_li();
        });
        $li = $li.not(':first');
    }
}

but now i cannot get any animation using the call

sp_animate_li(100);

Any help

thanks

Seldaek · Accepted Answer · 2011-01-30 17:01:38Z

1

You are not calling the inner function, nor returning it, so you can't actually call it. Try this:

function sp_animate_li(sp)
{
    console.log ( $li );
    function animate_li()
    {
        $li.filter(':first')
        .animate({
         height:  'show',
         opacity: 'show'
        }, sp, function(){
            animate_li();
        });
        $li = $li.not(':first');
    }
    return animate_li;
}

var inner = sp_animate_li(100);
inner(); // calls the inner function

answered Jan 30, 2011 at 17:01

Seldaek

42.3k10 gold badges100 silver badges78 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Pradyut Bhattacharya Over a year ago

oops... java and javascript are different... javascript can map variable to function... wow!!!

Felix Kling · Accepted Answer · 2011-01-30 19:27:01Z

1

Why not define your function as:

function animate_li($li, sp)
{
   sp = sp || 250;
   $li.first()
      .animate({
            height:  'show',
            opacity: 'show'
          }, 
          sp, 
          function(){
              animate_li($li.not(':first'), sp);
          }
      );
}

This also avoids the use of variables from higher scopes which can get confusing...

Update: Fixed recursive call.

edited Jan 30, 2011 at 19:27

answered Jan 30, 2011 at 17:03

Felix Kling

820k181 gold badges1.1k silver badges1.2k bronze badges

2 Comments

Pradyut Bhattacharya Over a year ago

this wont work as animate_li is a recursive function(being called by itself in line 9) otherwise it would work with original with only sp parameter... animate_li(sp)

Felix Kling Over a year ago

@Pradyut Bhattacharya: You should include your version in your question (edit your question) instead of posting it as an answer (if it is not an answer) and explain why it might not work. And sorry, I missed the recursive part, but it is easy to fix (what I did).

konrad.kruczynski · Accepted Answer · 2011-01-30 16:59:51Z

0

No wonder, cause animate_li isn't called anywhere. Why wouldn't you add parameter to animate_li instead of wrapping it?

answered Jan 30, 2011 at 16:59

konrad.kruczynski

48k6 gold badges39 silver badges47 bronze badges

Comments

Pradyut Bhattacharya · Accepted Answer · 2011-01-30 19:00:38Z

0

function animate_li( sp)
{
   sp = sp || 250;
   $li.filter(':first')
      .animate({
         height:  'show',
         opacity: 'show'
      }, sp, function(){
        animate_li( sp);
      });
    $li = $li.not(':first');
}

answered Jan 30, 2011 at 19:00

Pradyut Bhattacharya

5,75813 gold badges58 silver badges86 bronze badges

Collectives™ on Stack Overflow

parameterize a jquery function

4 Answers 4

1 Comment

2 Comments

Comments

Comments

Hot Network Questions

Collectives™ on Stack Overflow

4 Answers 4

1 Comment

2 Comments

Comments

Comments

Related