26

I have a Main.java and Test.java classes that I want to compile and run Main.java in Test.java code. Here is my code

    Process pro1 = Runtime.getRuntime().exec("javac Main.java");
    pro1.waitFor();
    Process pro2 = Runtime.getRuntime().exec("java Main");

    BufferedReader in = new BufferedReader(new InputStreamReader(pro2.getInputStream()));
    String line = null;

    while ((line = in.readLine()) != null) {
        System.out.println(line);
    }

I just print "ok" in Main.java but this code doesn't print anything. What is the problem ?

Improve this question
13
  • Looks like you're looking for docs.codehaus.org/display/JANINO/Home ;) . Commented Jan 30, 2011 at 11:44
  • @phihag it is just java code example. I will generalize it with c/c++ code and ohters Commented Jan 30, 2011 at 11:45
  • 1
    Aren't you supposed to use Process.getOutputStream? Commented Jan 30, 2011 at 11:47
  • What are the exitValue() 's of the processes? What do they output in ErrorStreams? Commented Jan 30, 2011 at 11:48
  • 3
    Works fine for me. Are you sure that java and javac are in the PATH? Does it work if you run those commands from the command line? You may also wish to use the javax.tools package for compiling if you want more control over the compiling process. Commented Jan 30, 2011 at 11:52

3 Answers 3

Reset to default
30

I have modified the code to include some checks:

public class Laj {

  private static void printLines(String name, InputStream ins) throws Exception {
    String line = null;
    BufferedReader in = new BufferedReader(
        new InputStreamReader(ins));
    while ((line = in.readLine()) != null) {
        System.out.println(name + " " + line);
    }
  }

  private static void runProcess(String command) throws Exception {
    Process pro = Runtime.getRuntime().exec(command);
    printLines(command + " stdout:", pro.getInputStream());
    printLines(command + " stderr:", pro.getErrorStream());
    pro.waitFor();
    System.out.println(command + " exitValue() " + pro.exitValue());
  }

  public static void main(String[] args) {
    try {
      runProcess("javac Main.java");
      runProcess("java Main");
    } catch (Exception e) {
      e.printStackTrace();
    }
  }
}

Here is the Main.java:

public class Main {
  public static void main(String[] args) {
    System.out.println("ok");
  }
}

When everything is fine, it just works:

alqualos@ubuntu:~/tmp$ java Laj
javac Main.java exitValue() 0
java Main stdout: ok
java Main exitValue() 0

Now, for example, if I have some error in Main.java:

alqualos@ubuntu:~/tmp$ java Laj
javac Main.java stderr: Main.java:3: package Systems does not exist
javac Main.java stderr:     Systems.out.println("ok");
javac Main.java stderr:            ^
javac Main.java stderr: 1 error
javac Main.java exitValue() 1
java Main stdout: ok
java Main exitValue() 0

It still prints "ok" because the previously compiled Main.class is still there, but at least you can see what exactly is happening when your processes are running.

Improve this answer
Sign up to request clarification or add additional context in comments.

4 Comments

+1. I put these two files in same package. It was my error. Thanks Sergey
@Addy, then you need to use getOutputStream() on the second process to feed the process the data it needs. Or just close that stream so the process gets EOF immediately.
how can we pass argument in this?
When i try to run both commands using && like this... javac Main.java && java Main -> it fails ... Can you help @sergey
0

You also need to 

pro2.waitFor();

because executing that process will take some time and you can't take the exitValue() before the process has finished.

Improve this answer

3 Comments

I did this bu this also don't give any answer
@hilal, you actually need to do it after your last loop. You read process'es output while it's running, that's okay, but you can access exitValue() only after it has finished.
@hilal, your code from the first edition worked fine for me with no changes. I'll post the code with checks, though.
0

I have added the condition in Laj class main function to check for compilation process has completed successfully or not..

public class Laj {

  private static void printLines(String name, InputStream ins) throws Exception {
    String line = null;
    BufferedReader in = new BufferedReader(
        new InputStreamReader(ins));
    while ((line = in.readLine()) != null) {
        System.out.println(name + " " + line);
    }
  }

  private static int runProcess(String command) throws Exception {
    Process pro = Runtime.getRuntime().exec(command);
    printLines(command + " stdout:", pro.getInputStream());
    printLines(command + " stderr:", pro.getErrorStream());
    pro.waitFor();
   // System.out.println(command + " exitValue() " + pro.exitValue());
    return pro.exitValue();
  }

  public static void main(String[] args) {
    try {
    int k =  runProcess("javac Main.java");
    if (k==0)
    k=runProcess("java Main");

    } catch (Exception e) {
      e.printStackTrace();
    }
  }
}
Improve this answer

1 Comment

the answer, care to further clarify?