changing bash variable names in loop

Question

I'd like to change the variable used within a bash loop. I'd like the first iteration to echo "/path/to/lol/hello_foo" and the second "/path/to/lol/hello_bar".

But instead, this is printed:

/path/to/lol/fname_one
/path/to/lol/fname_two

Here's the code:

#!/bin/bash                                                                                                                                                                                                                                                                              

path_data='/path/to/lol'
fname_one='hello_foo'
fname_two='hello_bar'

for count in one two
do
    echo $path_data/fname_$count
done

shouldn't you for loop say : for count in fname_one fname_two do echo $path_data/$count done — Satya
– Satya, Commented Jan 8, 2018 at 2:46

iamauser · Accepted Answer · 2018-01-08 03:05:27Z

2

See "How can I use variable variables (indirect variables, pointers, references) or associative arrays?"

Your script would look something like this,

 #!/bin/bash   

 path_data='/path/to/lol'
 fname_one='hello_foo'
 fname_two='hello_bar'

 for count in one two
 do
   _tmpf="fname_$count"
   echo "$path_data/${!_tmpf}" 
 done

Result:

~]# ./test.sh 
/path/to/lol/hello_foo
/path/to/lol/hello_bar

answered Jan 8, 2018 at 3:05

iamauser

11.6k6 gold badges40 silver badges57 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Gordon Davisson · Accepted Answer · 2018-01-08 03:05:26Z

You can use indirect variable expansion to do this:

...
fname_var=fname_$count
echo "$path_data/${!fname_var}"    # Quoting variable references is a good idea
...

But it's generally better to use arrays for things like this:

#!/bin/bash

path_data='/path/to/lol'
declare -a fname    # Make fname an array, rather than a plain variable
fname[1]='hello_foo'
fname[2]='hello_bar'

for count in 1 2
do
    echo "$path_data/${fname[count]}"
done

If you need text (not numeric) indexes you can use an associative array (bash v4 only):

#!/bin/bash

path_data='/path/to/lol'
declare -A fname    # Capital -A makes an associaltive array
fname[one]='hello_foo'
fname[two]='hello_bar'

for count in one two
do
    echo "$path_data/${fname[$count]}"
done

John3136 · Accepted Answer · 2018-01-08 03:07:06Z

1

You can do this with eval (which is probably outdated compared to some of the other answers)

#!/bin/bash

path_data='/path/to/lol'
fname_one='hello_foo'
fname_two='hello_bar'

for count in one two
do
    varname=fname_$count
    eval "varval=$"$varname
    echo $path_data/$varval
done

As noted by others an array is probably a better solution.

answered Jan 8, 2018 at 3:07

John3136

29.3k4 gold badges55 silver badges77 bronze badges

Collectives™ on Stack Overflow

changing bash variable names in loop

3 Answers 3

Comments

Comments

Comments

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

Comments

Comments

Related