JS if greater than condition not returning correct result

Question

I'm testing some client-side validation on my site and I've run into a bit of a snag.

var budget = document.forms["jobSubmit"]["currency-field"].value; 
var price = budget.replace("$", "");


if (Number(price) >= 9999) {
    alert("Budgets have a maximum of 9999 US dollars.");
    return false;
} else {
alert(price);   
}

return false;

When I try to do a simple greater than condition on my price field, it doesn't return the proper result.

So in this situation, despite that I put in 11111, the greater than isn't working.

However, if I were to switch it to < 10, for example, it'll work just fine and all numbers under 10 will trigger the condition.

Why is this happening?

In your picture there's a comma in the middle of 11,111.00 which is an invalid number. You will need to remove the commas or else Number("11,111.00") will return NaN. — castletheperson
– castletheperson, Commented Dec 30, 2017 at 3:53
Ah, right. Figured it was something simple like that. Thanks. — Felix
– Felix, Commented Dec 30, 2017 at 3:56

Mamun · Accepted Answer · 2017-12-30 03:57:24Z

1

Try the following:

var budget = "$111,111" 
var price = budget.replace("$", "").replace(',','');


if (Number(price) >= 9999) {
    alert("Budgets have a maximum of 9999 US dollars.");
    //return false;
} else {
  alert(price);   
}

answered Dec 30, 2017 at 3:57

Mamun

69k9 gold badges51 silver badges62 bronze badges

Sign up to request clarification or add additional context in comments.

4 Comments

Michael Cook Over a year ago

If you don't mind a dependency, the library "numeral.js" handles parsing of formatted numbers very well.

Mamun Over a year ago

@cadmium, that might be but that is OP's concern whether to use such library or not.

castletheperson Over a year ago

Or remove all invalid characters at once: budget.replace(/[^0-9.]/g, "")

Mamun Over a year ago

@4castle, yes we can do that. But I think , is allowed in amount. If other invalid characters are present we should consider that as invalid input...thanks.

Collectives™ on Stack Overflow

JS if greater than condition not returning correct result

1 Answer 1

4 Comments

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

4 Comments

Related