Angular response is undefined

Question

Trying to retrieve using angular the json found at: "https://api.github.com/users/angular", more precisely the id property from that json. Any thoughts on why this fails (in debug mode I get a

'response is not defined'

):

<html ng-app="myViewer">
<head>
<script data-require="angular.js@*" data-semver="1.2.25" src="https://code.angularjs.org/1.2.25/angular.js"></script>
</head>


<body ng-controller="MyController">
    {{ result.id }}
    {{ err }}
</body>

<script type="text/javascript">
(function() {

    var app = angular.module("myViewer", []);

    var MyController = function($scope, $http)
    {
        $http.get("https://api.github.com/users/angular")
        .then(function1, onerr);

        var function1 = function(response)
        {
            $scope.result = response.data;
        }
        var onerr = function(reason)
        {
            $scope.err = "nightmare";
        }

    }

    app.controller("MyController", ["$scope", "$http", MyController]);
}());

</script>
</html>

I expect the result to be the id that you can see by copying that link in your browser.

You're naming it MyController, but you have the var as SecondController, incongruity there. — rrd
– rrd, Commented Dec 5, 2017 at 15:26
fixed that was an error when i tried to simplify my code and namings for stackoverflow thank you — Sami
– Sami, Commented Dec 5, 2017 at 15:47

Paka · Accepted Answer · 2017-12-05 15:56:33Z

2

Here is a working fiddler https://jsfiddle.net/paka2/8roj37q9/1/

angular.module("myViewer", []).controller("myCtrl", function($scope,$http){
this.result = {};
this.err ;  
         $http.get("https://api.github.com/users/angular")
        .then(function1, onerr) ;
    function function1 (response)
    {    
      $scope.result = response.data;
    }
    function onerr (reason)
    {
      $scope.err = "nightmare";
    }
});

Hope it helps!!

answered Dec 5, 2017 at 15:56

Paka

1,05311 silver badges20 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Sami · Accepted Answer · 2017-12-05 15:48:49Z

1

Works if I correct the order:

var function1 = function(response)
{
    $scope.result = response.data;
}
var onerr = function(reason)
{
    $scope.err = "nightmare";
}

$http.get("https://api.github.com/users/angular")
.then(function1, onerr);

function1 should be defined before i call it with then.

answered Dec 5, 2017 at 15:48

Sami

41310 silver badges24 bronze badges

1 Comment

Paka Over a year ago

Yes. Function expressions are hoisted :)

Zooly · Accepted Answer · 2017-12-05 15:32:07Z

0

I think your promise is wrong.

  $http.get('https://api.github.com/users/angular').then(function(response){
    $scope.result = response.data;
  })

See same HTTP call working below:

https://plnkr.co/edit/8JqZ5NukHnHWGPxZ0GRr

answered Dec 5, 2017 at 15:32

Zooly

4,7974 gold badges40 silver badges55 bronze badges

Comments

Deepak Jha · Accepted Answer · 2017-12-05 15:36:04Z

0

try this i think you have incorrectly defined the controller as mycontroller and it should be SecondController instead.

 app.controller("MyController", ["$scope", "$http", SecondController ]);

answered Dec 5, 2017 at 15:36

Deepak Jha

1,61913 silver badges17 bronze badges

1 Comment

Sami Over a year ago

fixed that was an error when i tried to simplify my code and namings for stackoverflow thank you

Harshad Vaghela · Accepted Answer · 2017-12-05 15:54:50Z

0

Try with following

var function1 = function(response) { $scope.result = response; }

answered Dec 5, 2017 at 15:54

Harshad Vaghela

371 silver badge8 bronze badges

Collectives™ on Stack Overflow

Angular response is undefined

5 Answers 5

Comments

1 Comment

Comments

1 Comment

Comments

Hot Network Questions

Collectives™ on Stack Overflow

5 Answers 5

Comments

1 Comment

Comments

1 Comment

Comments

Related