angular module.run can only run inline function

Question

Why bellow code does not work:

<!DOCTYPE html>
<html ng-app="demo">
  <head>
    <meta charset="utf-8" />
    <title>Demo</title>
    <script type="text/javascript" src="https://cdnjs.cloudflare.com/ajax/libs/angular.js/1.6.6/angular.js"></script>
    <script>
      angular.module('demo',[])
      .factory('myFactory', function(){
        return {foo: function(){return 'bar';}};
      })
      .run(['myFactory', testFn(myFactory)]);

      function testFn(myFactory){alert(myFactory.foo());}
    </script>
  </head>
  <body ng-app="demo">
  </body>
</html>

But bellow code works:

<!DOCTYPE html>
<html ng-app="demo">
  <head>
    <meta charset="utf-8" />
    <title>Demo</title>
    <script type="text/javascript" src="https://cdnjs.cloudflare.com/ajax/libs/angular.js/1.6.6/angular.js"></script>
    <script>
      angular.module('demo',[])
      .factory('myFactory', function(){
        return {foo: function(){return 'bar';}};
      })
      .run(['myFactory', function(myFactory){
        alert(myFactory.foo());
      }]);
    </script>
  </head>
  <body ng-app="demo">
  </body>
</html>

In my application the function to run is lengthy so I don't want to put it inline the app.run because it looks really messy. How to do this?

felixmosh · Accepted Answer · 2017-12-03 06:55:11Z

1

Angular's run block requires a pointer to function, so without creating additional function you can rewrite it to something like that:

angular.module('app',[])
      .run(['myFactory', testFn]) // testFn is a pointer to the function.

edited Dec 3, 2017 at 6:55

answered Dec 2, 2017 at 19:50

felixmosh

35.8k10 gold badges81 silver badges98 bronze badges

Sign up to request clarification or add additional context in comments.

4 Comments

zipper Over a year ago

may you verify the code? it is short anyway. I don't know how to follow your instruction. I guess you mean .run(['myFactory', testFn]), and it does not work.

zipper Over a year ago

Sorry I did not get the meaning "testfn is a pointer to the function. Appreciate if you may change this plnkr to your version to illustrate it.

felixmosh Over a year ago

Sure, plnkr.co/edit/GUUqQrKCtroLoIs4UiVz?p=preview, it a simple optimisation.

zipper Over a year ago

Great. Thank you ;)

zipper · Accepted Answer · 2017-12-02 14:17:11Z

Sorry I'm a idiot. Fixed by this:

<!DOCTYPE html>
<html ng-app="demo">
  <head>
    <meta charset="utf-8" />
    <title>Demo</title>
    <script type="text/javascript" src="https://cdnjs.cloudflare.com/ajax/libs/angular.js/1.6.6/angular.js"></script>
    <script>
      angular.module('demo',[])
      .factory('myFactory', function(){
        return {foo: function(){return 'bar';}};
      })
      .run(['myFactory', function(myFactory){
        testFn(myFactory);
      }]);

      function testFn(myFactory) {alert(myFactory.foo());}
    </script>
  </head>
  <body ng-app="demo">
  </body>
</html>

Collectives™ on Stack Overflow

angular module.run can only run inline function

2 Answers 2

4 Comments

Comments

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

4 Comments

Comments

Related