VBScript throws "object variable not set" error

Question

Set sh = CreateObject("Wscript.Shell")
Set objFSO = CreateObject("Scripting.FileSystemObject")
Dim counter, myNum, fileLine
myNum = 0
counter = 9000000
Do While myNum < counter
    myNum = myNum + 1
    Call GetConnections()
Loop

Function GetConnections()
    i = 0
    outFile = "netband_logger_vbs.tmp"
    Set objFile = objFSO.CreateTextFile(outFile, True)
    Set shExec = sh.Exec("netstat -e")
    Do While Not shExec.StdOut.AtEndOfStream
        fileLine = shExec.StdOut.ReadLine()
        objFile.Write fileLine & vbCrLf
        objFile.Close
    Loop
End Function

I have the VBScript above. What I want to do is to run the netstat -e command 9000000 times and write every line of output to a text file line by line. And each time the after the first round of executions have terminated the script should overwrite the previous content of the netband_logger_vbs.tmp file with the values from the new round of executions.

Currently I have two problems: I can't seem to write the entire output to my .tmp file and I am also faced with an "object variable not set" error.

Ansgar Wiechers · Accepted Answer · 2017-10-14 01:34:51Z

1

The error you're getting is probably because you're closing the file handle after the first iteration. To fix this move the line objFile.Close after the loop.

With that said, I wouldn't recommend using the Exec method here anyway. In your scenario it's much easier to shell out to CMD and use output redirection:

sh.Run "%COMSPEC% /c netstat -e >""" & outFile & """", 0, True

answered Oct 14, 2017 at 1:34

Ansgar Wiechers

201k27 gold badges286 silver badges363 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Steven Black · Accepted Answer · 2017-10-14 01:44:24Z

0

As for why you can't get all the entire output into one file; the FAT32 filesystem has a 4GB cap, and if you're writing lot's of small .tmp files there's a directory cap.

And to prevent the file from being closed during a lapse in the StdOut stream move objFile.Close to after the Loop

answered Oct 14, 2017 at 1:44

Steven Black

2,2521 gold badge18 silver badges28 bronze badges

1 Comment

Ansgar Wiechers Over a year ago

He's overwriting the same file with each iteration, and I somehow doubt that a single netstat run would generate 4+ GB output. Not to mention that the 4 GB limitation only applies if he's using FAT32 in the first place. Which is also doubtful.

Collectives™ on Stack Overflow

VBScript throws "object variable not set" error

2 Answers 2

Comments

1 Comment

Linked

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

1 Comment

Linked

Related