php function return 0 or no return at all

Question

bit confused about function returns.
if i have a function with no real return needed, do i have to return 0 or return false to have a better code?

function example($time)
{
   echo $time
   //do i need to return 0 here?
};

$foodstore = array('bread','milk','meat','fruits','veges');
$buyer_list = array('bread', 'milk', 'chocolate');
function example($buyer_list , $foodstore)
{
   foeach($buyer_list as $item)
   {
       if(in_array($item, $foodstore)
        {
           return $item
        }
   }
//if i have to return only a specific $item, do i need to return 0 if no $item is specified.
}

function example($filename)
{
  $file = file_get_contents($filename);
...
  file_put_contents($filename, $file);
//do i need to return 0 here?
}

If the callers don't use the return value, you don't have to return anything. — Barmar
– Barmar, Commented Sep 8, 2017 at 23:21
If you don't return, it's effectively the same as return null;. — Barmar
– Barmar, Commented Sep 8, 2017 at 23:22
You shouldn't print anything from a function. It should be returned, and printed when calling the function. That being said, if the function doesn't need to return something, then don't. It's not s requirement. — Qirel
– Qirel, Commented Sep 8, 2017 at 23:57

Fabian N. · Accepted Answer · 2017-09-08 23:59:02Z

3

Just to clarify: For cleaner and more understandable code, you should always return something, if the function is not a void function. You have to ask yourself the question:

Why is the function not returning the desired result?
What should be returned in an error case?
Is it specified, when the function behaves different?
How can the caller react, if the result is unexpected.

For the last point it is necassary, that you can clearly see, what is the error value, for example by explicit add an return null; after your loop.

A good way to force you to think about your functions is to write Documentation like, PHPDoc

edited Sep 8, 2017 at 23:59

answered Sep 8, 2017 at 23:33

Fabian N.

1,28011 silver badges19 bronze badges

Sign up to request clarification or add additional context in comments.

2 Comments

Qirel Over a year ago

Your link is invalid.

Fabian N. Over a year ago

Fixed, just go to the main domain TLD.

Collectives™ on Stack Overflow

php function return 0 or no return at all

1 Answer 1

2 Comments

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

2 Comments

Related