Executing a try inside of a while loop in Python [duplicate]

Question

I am trying to send an email inside a while loop but if the sendmail fails, I want the script to log the error and continue:

while True:

input_state = GPIO.input(5)
if input_state == True:
    now = datetime.datetime.now().strftime("%m-%d-%y-%H%M%S")
    logging.debug('Motion detected at ' + now)
    name = 'tempimage.jpg'
    camera.capture(name)
    new_name = '/home/pi/image' + str(now) + '.jpg'
    os.rename(name, new_name)
    try:
        server = smtplib.SMTP( "smtp.gmail.com", 587 )
        server.starttls()
        server.login( '<login to gmail>', '<password>' )
        server.sendmail( 'Front Porch', '<myphone number>@vtext.com', 'Picture just taken on Front Porch' ) #Chuck
        server.close()
    else:
        logging.debug('Send of text failed ' + now)
    time.sleep(3)
else:
    now = datetime.datetime.now().strftime("%m-%d-%y-%H%M%S")
    logging.debug('No Motion ' + now)
    time.sleep(3)

When I execute this at boot it stalls at the try. I know this is a Duh moment in the making but really need it to work. Any help greatly appreciated.

You have a try with no except or finally. This isn't going to stall at the try; this is going to outright fail to compile. — user2357112
– user2357112, Commented Aug 29, 2017 at 23:44
Perhapse you meant except AppropriateExceptionType instead of else. — user2357112
– user2357112, Commented Aug 29, 2017 at 23:44
You guys are awesome! I knew this had to be a Duh moment. Many thanks, adding an Except capture as below fixed everything. — cedombek
– cedombek, Commented Aug 30, 2017 at 8:42

whackamadoodle3000 · Accepted Answer · 2017-08-29 23:48:52Z

input_state = GPIO.input(5)
if input_state == True:
    now = datetime.datetime.now().strftime("%m-%d-%y-%H%M%S")
    logging.debug('Motion detected at ' + now)
    name = 'tempimage.jpg'
    camera.capture(name)
    new_name = '/home/pi/image' + str(now) + '.jpg'
    os.rename(name, new_name)
    try:
        server = smtplib.SMTP( "smtp.gmail.com", 587 )
        server.starttls()
        server.login( '<login to gmail>', '<password>' )
        server.sendmail( 'Front Porch', '<myphone number>@vtext.com', 'Picture just taken on Front Porch' ) #Chuck
        server.close()
    except Exception as e:
        logging.debug('Send of text failed ' + now + 'Exception '+e)
    time.sleep(3)
else:
    now = datetime.datetime.now().strftime("%m-%d-%y-%H%M%S")
    logging.debug('No Motion ' + now)
    time.sleep(3)

Try this code (I used except, not else and recorded the exception).

Collectives™ on Stack Overflow

Executing a try inside of a while loop in Python [duplicate]

1 Answer 1

1 Comment

Linked

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

1 Comment

Linked

Related