Javascript if doesn't work

Question

I'm new to javascript and I was making a simple program to reply but the if statement doesn't work. Here's my code :

var myInput = document.getElementById('myInput');
var myBtn = document.getElementById('btn');
var value = document.getElementById('myInput').value;
var answer = document.getElementById('answer');
var question = "Hi";

function message() {
  if ( value == question) {
   answer.innerHTML = "Hi, how can i help you?";
  } else {
   answer.innerHTML = "Hi ...";
  }
}

and here's the html part:

<input id="myInput" type="text">
<button id="myBtn" type="button" onclick="message()">Send!</button>
<p id="answer"></p>

I assure you ifs work. Your data must be something other than what you expect. What debugging have you done? — Carcigenicate
– Carcigenicate, Commented Aug 26, 2017 at 19:28
It takes value only once from the input, at the start of the program, and then never updates even if you enter something into the input… — deceze
– deceze ♦, Commented Aug 26, 2017 at 19:29

spanky · Accepted Answer · 2017-08-26 19:31:27Z

The problem is that you're fetching the value before you have a chance to fill it in.

Instead, fetch it inside the message function.

var myInput = document.getElementById('myInput');
var myBtn = document.getElementById('btn');
var answer = document.getElementById('answer');
var question = "Hi";

function message() {
  var value = document.getElementById('myInput').value;
  if (value == question) {
    answer.innerHTML = "Hi, how can i help you?";
  } else {
    answer.innerHTML = "Hi ...";
  }
}

<input id="myInput" type="text">
<button id="myBtn" type="button" onclick="message()">Send!</button>
<p id="answer"></p>

Sajeetharan · Accepted Answer · 2017-08-26 19:32:17Z

Place your var value = document.getElementById('myInput').value; inside the button click function

DEMO

var myInput = document.getElementById('myInput');
var myBtn = document.getElementById('btn');

var answer = document.getElementById('answer');
var question = "Hi";

function message() {
   var value = document.getElementById('myInput').value;
  console.log(value);
  console.log(question);
  if (value === question) {
   answer.innerHTML = "Hi, how can i help you?";
  } else {
   answer.innerHTML = "Hi ...";
  }
}

<input id="myInput" type="text">
<button id="myBtn" type="button" onclick="message()">Send!</button>
<p id="answer"></p>

Collectives™ on Stack Overflow

Javascript if doesn't work

2 Answers 2

Comments

Comments

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Related