Calling javascript function from another function is not working

Question

I want to use the JsonObject value in a function which is defined in another function, so I am using it like below.

function downloadPDF(e) {
setImagesUploadedFile(objValue); // another function
var obj = objValue[0].Filename;
var filePath = SharedFilePath + obj;
$('#ImgSignedDoc').attr('href', filePath);}

And that function setImagesUploadedFile(objValue); is here like this

function setImagesUploadedFile(JsonObject) {
for (i = 0; i < JsonObject.length; i++) {
    var obj = JsonObject[i].Filename;
    var obj2 = "ImgSignedDoc";
    var obj3 = JsonObject[i].FileType;
    var datafileName = JsonObject[0].ImageName;

    var ImgObj = parent.document.getElementById(obj2);
    var Filename = datafileName.substring(datafileName.lastIndexOf('//') + 1);
    ImgObj.innerText = Filename;
    $(ImgObj).attr("data-filename", Filename);
}

}

and the error it shows is

0x800a1391 - JavaScript runtime error: 'objValue' is undefined

So what should I do or change in order to get the parameteres of setImagesUploadedFile(objValue) in my another function ??

variable objValue is not defined in your downloadPDF function — qiAlex
– qiAlex, Commented Aug 4, 2017 at 6:16
What is objValue when you call it in the function downloadPDF? Did you assign it somewhere? — Tree Nguyen
– Tree Nguyen, Commented Aug 4, 2017 at 6:17
you are passing setImagesUploadedFile(objValue);// objValue as argument but not defined. What you want exactly? — Honey
– Honey, Commented Aug 4, 2017 at 6:18
@Hornet: I want to use the parameters of JsonObject in my downloadPDF function — HEEN
– HEEN, Commented Aug 4, 2017 at 6:19
Where is a value returned from setImagesUploadedFile() call? — guest271314
– guest271314, Commented Aug 4, 2017 at 6:23

Keith · Accepted Answer · 2017-08-04 06:47:59Z

The problem is before you even start: objValue is never declared and populated.

function downloadPDF(e) {
    // At this point objValue is undefined
    setImagesUploadedFile(objValue); // another function

    var obj = objValue[0].Filename;
    var filePath = SharedFilePath + obj;
    $('#ImgSignedDoc').attr('href', filePath);
}

Try using 'use strict' declarations to better errors here as it will cause errors on the undeclared variable reference, rather than when it is used.

I think you're trying to treat objValue as a reference - that works for edits but not instantiation (JS has no out parameter), so use a return instead:

function downloadPDF(e) {
    'use strict';
    var json = // However you get your JSON data...
    var objValue = setImagesUploadedFile(json); 
    ...

Then, in setImagesUploadedFile:

function setImagesUploadedFile(jsonObject) {
    'use strict';
    var result = [];
    if(jsonObject) // Check we were passed the object
        for (var i = 0; i < jsonObject.length; i++) {
            ...
            var imgObj = ...

            // Add the result to the expected output array
            result.push(imgObj);
        }

    // Return the output array
    return result; 
}

So, steps to fix this:

Add 'use strict'; to get better errors.
Declare variables before you use them.
Use return from a function to get values out.

Finally, as a side note, there's a convention in JS to use camelCase for functions and variables, and only use CapitalCase for classes and functions that expect to be called with new. You don't have to use it, but it can help make your code easier to understand.

i know the error part. what steps should I take to resolve this? Please suggest
@VVVV I'm guessing you commented on the first edit? Your fundamental problem is objValue is never declared and populated - I've fleshed out the answer with suggestions on how to fix that.
getting error as 0x800a138f - JavaScript runtime error: Unable to get property 'length' of undefined or null reference. I used your latest answer but getting error
now I get error as 0x800a1391 - JavaScript runtime error: 'JsonObject' is undefined

Khizar Iqbal · Accepted Answer · 2017-08-04 06:25:03Z

function downloadPDF(e) {
    // objValue is not declared, is this a global variable, if yes then declare it before calling the downloadPDF function.
    setImagesUploadedFile(objValue); // another function
    var obj = objValue[0].Filename;
    var filePath = SharedFilePath + obj;
    $('#ImgSignedDoc').attr('href', filePath);
}

var objValue = [];
downloadPDF(e);

or you can get the values of the objValue from where you want like:

var objValue = $("#id or class");
downloadPDF(e);

Nipun · Accepted Answer · 2017-08-04 07:35:18Z

0

You need to define objValue before passing into function. Eg:

function downloadPDF(e)
{ 
    var objValue = {key1: value, key2: value};
    setImagesUploadedFile(objValue); // another function var obj = 
    objValue[0].Filename; var filePath = SharedFilePath + obj; 
    $('#ImgSignedDoc').attr('href', filePath);
}

edited Aug 4, 2017 at 7:35

Nipun

2,2715 gold badges24 silver badges39 bronze badges

answered Aug 4, 2017 at 6:52

Mohan Lal

1

Collectives™ on Stack Overflow

Calling javascript function from another function is not working

3 Answers 3

11 Comments

Comments

Comments

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

11 Comments

Comments

Comments

Related