Django image upload issue

Question

I'm trying to upload an image. This is an avatar image for the profile of the user.

Currently, the form return no error, but I have nothing written on my database or in my folder media/avatar/.

What's wrong ?

My view :

def view_avatar(request):
    if request.method == 'POST':
        form = UploadFileForm(request.POST, request.FILES, instance=request.user.profile)
        if form.is_valid():
            form.save()            
    else:
        form = UploadFileForm(instance=request.user.profile)
    return render(request, 'avatar.html', locals())

My form :

class UploadFileForm(forms.ModelForm):
    class Meta:
        model = Profile
        fields = ('avatar',)

My model :

class Profile(models.Model):
    user = models.OneToOneField(User, on_delete=models.CASCADE)
    birthdate = models.DateField(null=True, blank=True)
    avatar = models.ImageField(upload_to='media/avatar/', blank=True, null=True)

Answer 1

It's because the form which you are using is inherited from forms.Form , you need to use forms.ModelForm for saving the instance directly.

Change this line,

class UploadFileForm(forms.ModelForm):
    class Meta:
        model = Profile
        fields = ('avatar', )

    def save(self, *args, **kwargs):
        profile, created = Profile.objects.get_or_create(user=self.user)
        profile.avatar = self.cleaned_data['avatar']
        profile.save()
        return profile

Also, edit in your views like this,

if form.is_valid():
    file = form.save(commit=False)
    file.user = request.user
    file.save()

Answer 2

For making a profile you can use signals.

This way whenever a new user been added, a profile will be generated for that user automatically

Your models.py:

from django.conf import settings
from django.db.models.signals import post_save


class Profile(models.Model):
    user = models.OneToOneField(settings.AUTH_USER_MODEL)
    birthdate = models.DateField(null=True, blank=True)
    avatar = models.ImageField(upload_to='media/avatar/%y/%m/%d', blank=True, null=True)


def post_save_profile(sender, instance, created, *args, **kwargs):
    if created:
        try:
            Profile.objects.create(user=instance)
        except:
            pass

post_save.connect(post_save_profile, sender=settings.AUTH_USER_MODEL)

and for updating the information like birthday and avatar you can use ModelForm.

forms.py:

class UploadFileForm(forms.ModelForm):
    class Meta:
        model = Profile
        fields = ('birthdate', 'avatar')

    def __init__(self, *args, **kwargs):
        super(UploadFileForm, self).__init__(*args, **kwargs)
        self.fields['avatar'].required = False

your views.py:

def view_avatar(request):
    user = request.user
    if request.method == "POST":
        form = UploadFileForm(request.POST, request.FILES, instance=user.profile)
            if form.is_valid():
                form.save()

for avatar in template you can use this:

<img src="{% if user.profile.avatar %}{{ user.profile.avatar.url }}{% else %}{% static 'no-avatar.jpg' %}{% endif %}"><i></i>

Answer 3

You can write custom Save method for this like this.

View:

def view_avatar(request):
    if request.method == 'POST':
        form = UploadFileForm(request.POST, request.FILES, user=request.user)
        if form.is_valid():
            form.save()

    else:
        form = UploadFileForm()
    return render(request, 'avatar.html', locals())

Form:

class UploadFileForm(forms.Form):
    class Meta:
        model = Profile
        fields = ('avatar', )

    def __init__(self, *args, **kwargs):
        self.user = kwargs.pop('user', None)
        super(UploadFileForm, self).__init__(*args, **kwargs)
        self.fields['avatar'].required = False

    avatar = forms.FileField()


    def save(self, *args, **kwargs):
        user_profile, created = Profile.objects.get_or_create(user=self.user)
        user_profile.avatar = self.cleaned_data.get('avatar')
        user_profile.save()
        return user_profile

Answer 4

I forgot the enctype ! The solution was :

<form method="POST" action="" enctype="multipart/form-data">