problem with closure in preg_replace_callback

Question

This script check every line of some text for "FIRST" and "LAST" words, and trying to replace them by entries in $temp_names array.

$temp_names = array('FIRST' => array('John','Jack'),'LAST' => array('Doe','Smith'));

for ($i=0; $i < count($lines); $i++)
{ 
  $lines[$i] = preg_replace_callback("/FIRST|LAST/",
                                        function($matches) use ($temp_names){ 
                                        return array_shift($temp_names[$matches[0]]); }, $lines[$i]);

}

i have problem with return array_shift() in closure function. It correctly returns the first entry, but the entry stays in array. So every time it return "John" and "Doe". Why is that?

thanks.

salathe · Accepted Answer · 2010-12-18 18:01:48Z

2

In order to have any changes to the $temp_names array (such as shifting a value), you need to use it by reference like

function ($matches) use (&$temp_names)

answered Dec 18, 2010 at 18:01

salathe

52.1k12 gold badges108 silver badges134 bronze badges

Sign up to request clarification or add additional context in comments.

Collectives™ on Stack Overflow

problem with closure in preg_replace_callback

1 Answer 1

Comments

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

Comments

Related