Adding an value to multidimensional array in c# asp.net

Question

I need to add values in an multidimensional array whitin an while loop. But I don't know how.

public Array getDailyAvgRatingByCompanyId(int companyId, int periodStart = 0, int periodEnd = 0)
        {
            int[,] arr = { { }, { } };

            string queryString = "SELECT num_ratings_day, rating_gem, daymonthyear FROM company_rating_daily_avg WHERE company_id = " + companyId + " ORDER BY daymonthyear ASC";
            SqlDataReader myDataReader = Database.sqlDataReader(queryString);

            if (myDataReader.HasRows)
            {
                while (myDataReader.Read())
                {
                    //Something like arr[0].Push(myDataReader['num_ratings_day']
                }
            }

            return arr;
        }

You might want to consider using parameterised SQL instead of what you have, to avoid SQL injection attacks. — Graham Clark
– Graham Clark, Commented Dec 9, 2010 at 13:56
Just a thought - To simplify this you could return say a List<DailyAvgRating> or ArrayList where DailyAvgRating is a class/struct/model that contains CompanyId, and your SQL columns (e.g. Num_Rating_Day, Rating_Gem, DayMonthYear) result. — byte
– byte, Commented Dec 9, 2010 at 13:58
@Graham Clark: I get what you're saying and on the whole parametrised queries are safer, but since Boyd is only inputting numbers, there is no SQL injection vector here. — Matt Ellen
– Matt Ellen, Commented Dec 9, 2010 at 14:13
what do the indices of your array represent, boyd? is it arr[row, col]? — Matt Ellen
– Matt Ellen, Commented Dec 9, 2010 at 14:15
@Matt it must be filled with data to be handled by an graph class. So it must contain values for the x and y. Like { {x1, x2, x3}, {y1, y2, y3} } — Boyd
– Boyd, Commented Dec 9, 2010 at 14:18

Matt Ellen · Accepted Answer · 2010-12-09 14:27:13Z

This assumes that you want all the columns in the query put into the array, and that all the columns return ints.

public Array getDailyAvgRatingByCompanyId(int companyId, int periodStart = 0, int periodEnd = 0)
{
    List<int[]> rowList = new List<int[]>();

    string queryString = "SELECT num_ratings_day, rating_gem, daymonthyear FROM company_rating_daily_avg WHERE company_id = " + companyId + " ORDER BY daymonthyear ASC";
    SqlDataReader myDataReader = Database.sqlDataReader(queryString);

    if (myDataReader.HasRows)
    {
        while (myDataReader.Read())
        {
            int[] values = new int[3];
            values[0] = myDataReader['num_ratings_day'];
            values[1] = myDataReader['rating_gem'];
            values[2] = myDataReader['daymonthyear'];
            rowList.add(values);
        }
    }

    int[,] arr = new int[rowList.Count, 3];

    for(int i = 0; i < rowList.Count; ++i)
    {
        for(int j = 0; j < 3; ++j)
        {
            arr[i,j] = rowList[i][j];
        }
    }

    return arr;
}

John Gietzen · Accepted Answer · 2010-12-09 13:53:56Z

1

You should use a data type other than Array for this.

Try using a List of arrays:

var list = new List<int[]>();

if (myDataReader.HasRows)
{
    while (myDataReader.Read())
    {
        var int1 = ??; // Get data 1
        var int2 = ??; // Get data 2

        list.Add(new[] { int1, int2 });
    }
}

answered Dec 9, 2010 at 13:53

John Gietzen

49.7k32 gold badges151 silver badges191 bronze badges

2 Comments

Boyd Over a year ago

Problem is that I don't have a choice.. I need to fill the array excactly this way because that's how the data is handled by another part of the system.

Si8 Over a year ago

This works, except mines are string instead of int. How can I sort the list by string2 (int2) in your case?

wickie79 · Accepted Answer · 2010-12-09 14:00:30Z

0

You could use a DataTable by creating a SqlDataAdapter (with SELECT Statement), and than DataAdapter.Fill(DataTable). So you retrieve a DataTable with all values returned by sql statement

answered Dec 9, 2010 at 14:00

wickie79

4701 gold badge3 silver badges7 bronze badges

Collectives™ on Stack Overflow

Adding an value to multidimensional array in c# asp.net

3 Answers 3

Comments

2 Comments

Comments

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

2 Comments

Comments

Related