Python: How to do nested enumerate for loop?

Question

I have two files, file1 and file2, and for every file1 line, I’m trying to check against all the lines of file2.

So I did a nested enumerate for loop, but checking the first line of file1 against all the lines of file2, the program just completes, rather than moving onto the next file1 line to check against all the lines of file2.

Here is what I have:

def testing():
    file1 = open(‘file1.txt’, 'r')
    file2 = open(‘file2.txt’, 'r')

    for index1, line1 in enumerate(file1):
        for index2, line2 in enumerate(file2):
                #              Here it prints the first line of `file1.txt` and after checking against all the lines of `file2.txt` (`for index2, line2 in enumerate(file2.txt)`) it completes, rather then going to the outer loop and proceed looping
                print("THIS IS OUTER FOR LOOP LINE: " + line1 + " WITH LINE NUMBER: " + str(index1))

    file1.close()
    file2.close()

How can I check every line of file1 against all the lines of file2? What could I be doing wrong here?

Thank you in advance and will be sure to upvote/accept answer

you could use file2.readlines() to load the contents of the second file into memory and iterate over that data then — Felix
– Felix, Commented Apr 6, 2017 at 18:17

Prune · Accepted Answer · 2017-04-06 18:17:23Z

4

Push the position of file2 back to the start at the top of each loop. Either close and reopen it as aryamccarthy suggested, or do it the cleaner way by simply moving the pointer:

file1 = open(‘file1.txt’, 'r')
file2 = open(‘file2.txt’, 'r')

for index1, line1 in enumerate(file1):
    file2.seek(0)  # Return to start of file
    for index2, line2 in enumerate(file2):

answered Apr 6, 2017 at 18:17

Prune

78k14 gold badges63 silver badges83 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Arya McCarthy · Accepted Answer · 2017-04-06 18:13:19Z

1

You need to reopen file2 on every iteration. Move that code inside the loop. Otherwise, you reach the end of file2 after the first outer iteration, and you have nothing left to iterate over in the next round of the outer loop.

answered Apr 6, 2017 at 18:13

Arya McCarthy

8,8544 gold badges39 silver badges59 bronze badges

1 Comment

Arya McCarthy Over a year ago

I should note in hindsight that my solution is subject to a race condition. Use Prune's answer instead.

Mateo Torres · Accepted Answer · 2017-04-06 18:17:39Z

0

I would keep every line of each file in separate lists

with open(file1) as f:
    content_1 = f.readlines()

with open(file2) as f:
    content_2 = f.readline()

and then proceed to compare the lists

for index1, line1 in enumerate(content_1):
    for index2, line2 in enumerate(content_2):
        # do your stuff here

answered Apr 6, 2017 at 18:17

Mateo Torres

1,6251 gold badge14 silver badges24 bronze badges

2 Comments

Arya McCarthy Over a year ago

With this, you have to store the full contents of each file in memory, which can be risky (or fail) for very large input files.

Mateo Torres Over a year ago

agreed, this is not an ideal solution for very big files, but for files of a couple thousand lines it should be ok... when dealing with very big files a better (but slower) idea would be to reopen the second file every time

Collectives™ on Stack Overflow

Python: How to do nested enumerate for loop?

3 Answers 3

Comments

1 Comment

2 Comments

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

1 Comment

2 Comments

Related