C# Array Don't Work at for loop

Question

My Code:

DataTable dt = fs.DataTable;
int columnsNumber = dt.Columns.Count;
string[] array = new string[columnsNumber];

for (int k=0; k==columnsNumber; k++)
{ 
    array[k] = dt.Columns[k].ColumnName;
}


foreach (var item in array)
{
    MessageBox.Show(item);
}

MessageBox has displaying the blank message.

If I have run this code, no problem;

array[1] = dt.Columns[1].ColumnName; 
array[2] = dt.Columns[2].ColumnName; 
array[3] = dt.Columns[3].ColumnName;

This work. What is the problem ?

Yousaf · Accepted Answer · 2017-03-04 18:12:55Z

2

You have included a == operator in for loop where you should be using <

Change

for (int k=0; k==kolonSayisi; k++)

to

for (int k=0; k<kolonSayisi; k++)

answered Mar 4, 2017 at 18:12

Yousaf

29.5k6 gold badges53 silver badges78 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

justin.m.chase · Accepted Answer · 2017-03-04 18:16:01Z

2

Your cicle just checking k==kolonSayisi:

for (int k=0; k==kolonSayisi; k++)
{ 
    array[k] = dt.Columns[k].ColumnName;
}

I think you should write it like this:

for (int k=0; k < columnsNumber; k++)
{ 
    array[k] = dt.Columns[k].ColumnName;
}

edited Mar 4, 2017 at 18:16

justin.m.chase

13.7k9 gold badges61 silver badges111 bronze badges

answered Mar 4, 2017 at 18:12

eocron

7,5962 gold badges27 silver badges62 bronze badges

Comments

Claudiu A · Accepted Answer · 2017-03-04 19:08:34Z

1

You can also use this way

var listToArray = new listToArray<string>();
foreach (DataColumn dataCol in dt.Columns)
    listToArray.Add(dataCol.ColumnName);
listToArray.ToArray();

Hope it helps.

edited Mar 4, 2017 at 19:08

answered Mar 4, 2017 at 18:55

Claudiu A

5871 gold badge6 silver badges14 bronze badges

Comments

Mong Zhu · Accepted Answer · 2017-03-04 18:45:16Z

A for loop works the following way:

In the parentheses the first part defines a counting or increment variable and sets the starting value. The second part is the cancel condition. You can read it like: if condition is false then stop the loop. The third part defines the step size, how you want to increment your variable.

Now if you look at your condition k==columnsNumber you are trying to check if k equals the number. In the first iteration where k is 0 it will return false if columnsNumber is not 0. So your loop will stop.

Mong Zhu · Accepted Answer · 2017-03-04 18:58:17Z

0

You can use like this:

       DataTable table = new DataTable();

        table.Columns.Add("col1");
        table.Columns.Add("col2");
        table.Columns.Add("col3");

        var array = table.Columns
            .Cast<DataColumn>()
            .Select(c => c.ColumnName)
            .ToArray();

        foreach(var item in array)
        {
            MessageBox.Show(item);
        }

edited Mar 4, 2017 at 18:58

Mong Zhu

23.8k10 gold badges47 silver badges81 bronze badges

answered Mar 4, 2017 at 18:16

Sargis Ghazaryan

1041 silver badge2 bronze badges

Collectives™ on Stack Overflow

C# Array Don't Work at for loop

5 Answers 5

Comments

Comments

Comments

Comments

Comments

Hot Network Questions

Collectives™ on Stack Overflow

5 Answers 5

Comments

Comments

Comments

Comments

Comments

Related