ASP.NET MVC Model Binding in Complex ViewModel Object

Question

Here is my Complex ViewModel

public class OperationStudyInputViewModel
{
    public OperationStudy OperationStudy { get; set; }
    public FileUpload FileUploads { get; set; }
    public IEnumerable<string> Attachments { get; set; }
    public IEnumerable<string> Folders { get; set; }
}

Here is the OperationStudy Model

public class OperationStudy
{
    public int OperationStudyId { get; set; }
    public string SpCategoryId { get; set; }
    //Here is some Other Properties
}

Here is the OperationStudyInput() Post Method

[HttpPost]

public ActionResult OperationStudyInput([Bind(Exclude = "SpCategoryId")] OperationStudyInputViewModel inputViewModel, IEnumerable<HttpPostedFileBase> multiplefiles)
{
    // some Necessary codes Here
    _dbContext.OperationStudies.Add(inputViewModel.OperationStudy);
    _dbContext.SaveChanges();
}

I want to exclude SpCategoryId From OperationStudy in inputViewModel(inputViewModel.OperationStudy) in OperationStudyInput() Post mehtod. I have tried with the previous code but its not working as expected!!

Any Help Please!!

A view model should not contain a data model. Create a view model for OperationStudy and omit the OperationStudyId property. (and when you use a view model you never need a [Bind] attribute - that's one of the many reasons why you use a view model. — user3559349
– user3559349, Commented Feb 26, 2017 at 8:39
Yes! I can do this but Is it possible what I have wanted here?? — TanvirArjel
– TanvirArjel, Commented Feb 26, 2017 at 8:42
Yes, but its awful practice so don't consider it - [Bind(Exclude = "OperationStudy.SpCategoryId")] — user3559349
– user3559349, Commented Feb 26, 2017 at 8:47
@Stephen Muecke It doesn't work..I had tried it long ago and now but unfortunately no luck.. — TanvirArjel
– TanvirArjel, Commented Feb 26, 2017 at 8:57

Ilya Chernomordik · Accepted Answer · 2017-02-26 09:11:28Z

I would recommend to distinguish between view models and data models that you have. If you return directly then it can lead to unexpected security troubles (suddenly adding a field in backend will lead to this field exposed to web). So what I would do is create a number of web models, that you can suffix with Web e.g. and do a mapping each time you need to return it.

This will provide a good separation between your view and BI layers. To help you achieve that you can use frameworks like AutoMapper. It is not necessary, but helps you with crud mapping.

You might think this is an overkill, but trust me, you will see advantages of this approach in the long run. You can search more on google about the topic of separation as well.

P.S. I would not suggest any hacks with removing the data from model like suggested in other posts. This seems like a very fragile approach to me.

Prateek Pandey · Accepted Answer · 2017-02-26 10:46:10Z

0

You can specify the Bind attribute over the class like this:

[Bind(Exclude = "SpCategoryId")]
public class OperationStudy
{
    public int OperationStudyId { get; set; }
    public string SpCategoryId { get; set; }
}

But, I would recommend to create and use separate ViewModel for binding.

answered Feb 26, 2017 at 10:46

Prateek Pandey

8636 silver badges20 bronze badges

Collectives™ on Stack Overflow

ASP.NET MVC Model Binding in Complex ViewModel Object

2 Answers 2

Comments

Comments

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Related